[APM] Distributed Tracing #24062

sorenlouv · 2018-10-16T07:55:16Z

WIP

elasticmachine · 2018-10-16T09:34:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-16T19:55:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-16T21:02:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-17T19:59:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

* Adds traces overview with mock data * Updates service overview snapshots * Updates based on review feedback * Adds tests for ManagedTable and ImpactBar * Refactored transaction overview to use new managed table component * Fixes tab size * Cleans up some tests and types * Cleans up types and tests * kbn bootstrap changes to x-pack yarn.lock * Removed jsconfig file in apm * Updates snapshot tests * Reversed bogus yarn lock change in x-pack * review feedback wip * Resolves typescript issues

Refactoring includes: * ImpactBar component to align EuiProgress usage for impact bars * Sharing some logic between transaction and trace queries * Typescript support

Fix tests Make interfaces versioned Fix ts issues Rename eventType to docType WIP Working prototype Fix tests Limit get_transaction by trace.id

* [APM] use react-redux-request * Stricter type checking

elasticmachine · 2018-10-18T12:54:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-18T14:53:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-18T16:03:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-18T16:49:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sorenlouv · 2018-10-18T21:16:26Z

package.json

@@ -167,7 +167,7 @@
    "react-input-range": "^1.3.0",
    "react-markdown": "^3.1.4",
    "react-redux": "^5.0.7",
-    "react-router-dom": "4.2.2",
+    "react-router-dom": "^4.3.1",


@jasonrhodes We should make sure this doesn't have any breaking changes.

It’s a minor update so it can’t be breaking.

lol - yeah the other package.json had the caret so the newer version was already installed there when we were getting that TS error yesterday, I think. I’ll take a look at the change log.

* [APM] Display transaction info on span flyout * Add links * Fix tests * Eui fixes * Remove color from span type

elasticmachine · 2018-10-18T21:52:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-18T22:09:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T10:57:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T16:12:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Duplicates transaction properties table for use in flyout, with dummy values * Brings in real location and url param data for transaction flyout * Converts flyout to TS * Adds query param state for flyouts with ts support * Updates styles and uses EuiTabs for transaction flyout * Updates type references after rebase * Updated index var name per review feedback * WIP transaction flyout * WIP transaction flyout * WIP * Fixes waterfall helpers after rebasing span flyout changes * Finalizes styling for transaction flyover from timeline * Fixes layout for span flyout header * Removed accidentally committed file (should be in other branch) * Small tweaks to the sticky property layout styling * Updates snapshot tests after sticky properties converting to EUI * Final review tweaks for TS

elasticmachine · 2018-10-19T21:30:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [APM] Minor docs cleanup * Fix tests * Make `text` required * Simplify documentation module * Break docs into separate files * Remove `translateAgentName` method * Formatting

elasticmachine · 2018-10-22T22:48:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-22T23:57:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T09:28:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sorenlouv · 2018-10-23T11:39:29Z

retest

elasticmachine · 2018-10-23T13:58:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Transaction sample header completed * Fixes link target for traces overview to include trans/trace ids as query params * Converts Transaction index file to TS * Adds trace link to sample section * Refactors the trace link and applies it to two usages * Implements transaction sample action context menu * Calculates and implements duration percentage * Re-typed how transaction groups work * Fixes transaction flyout links and context menu * Removes unnecessary ms multiplication * Removes unused commented code * Finalizes infra links * Fixes some type shenanigans

elasticmachine · 2018-10-23T18:28:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sorenlouv · 2018-10-23T18:30:10Z

x-pack/plugins/apm/public/components/app/ServiceOverview/ServiceList/index.js

+  if (value === 0) {
+    return '0';
+  }
+  const formatted = numeral(value).format('0.0');


Suggested change

const formatted = numeral(value).format('0.0');

const formatted = asInteger(value);

sorenlouv · 2018-10-23T18:32:04Z

x-pack/plugins/apm/public/components/app/TraceOverview/TraceList.tsx

+
+function formatString(value: string) {
+  return value || 'N/A';
+}


This is unnecessary. With typescript we know that transaction.transaction.name and transaction.context.service.name will always be defined.

Sounds good -- I can clean these little things up in my beta ticket so we don't make this PR restart CI too many more times before getting it into master. :)

Sorry, didn't mean to hold up the merge. Just adding notes for future fix. Non of this is blocking.

elasticmachine · 2018-10-23T19:37:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T20:29:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sorenlouv · 2018-10-23T21:58:08Z

x-pack/plugins/apm/typings/Transaction.ts

+    pid: number;
+  };
+  service: ContextService;
+  system: ContextSystem;


sorenlouv · 2018-10-23T21:58:18Z

x-pack/plugins/apm/typings/Transaction.ts

+  architecture: string;
+  hostname: string;
+  ip: string;
+  platform: string;


All are optional:
https://github.com/elastic/apm-server/blob/master/docs/spec/system.json

* Adds traces overview with mock data (#22628) * Updates service overview snapshots * Adds tests for ManagedTable and ImpactBar * Refactored transaction overview to use new managed table component * Removed jsconfig file in apm * [APM] Distributed tracing - Trace details (waterfall) (#22763) * [APM] Add typescript to waterfall (#23635) * [APM] Migrate get_trace and constants to Typescript (#23634) * [APM] Add types for setup_request (#23762) * [APM] Adds trace overview queries and some refactoring (#23605) * ImpactBar component to align EuiProgress usage for impact bars * Sharing some logic between transaction and trace queries * Typescript support * Quick fix ‘banana’ * [APM] Ensure backwards compatibility for v1 and v2 (#23636) * Make interfaces versioned * Rename eventType to docType * Fixes trace links on traces overview (#24089) * [APM] use react-redux-request (#24117) * Updated yarn lockfile for new yarn version * Updated dependency issues for react-router-dom types * [APM] Display transaction info on span flyout (#24189) * [APM] Display transaction info on span flyout * Brings in real location and url param data for transaction flyout * Converts flyout to TS * Adds query param state for flyouts with ts support * Updates styles and uses EuiTabs for transaction flyout * [APM] Transaction flyout * [APM] Minor docs cleanup (#24325) * [APM] Minor docs cleanup * [APM] Fix issues with v1 spans (#24332) * [APM] Add agent marks (#24361) * [APM] Typescript migration for the transaction endpoints (#24397) * [APM] DT transaction sample header (#24294) Transaction sample header completed * Fixes link target for traces overview to include trans/trace ids as query params * Converts Transaction index file to TS * Adds trace link to sample section * Refactors the trace link and applies it to two usages * Implements transaction sample action context menu * Calculates and implements duration percentage * Re-typed how transaction groups work * Fixes transaction flyout links and context menu * Removes unnecessary ms multiplication * Removes unused commented code * Finalizes infra links * Fixes some type shenanigans

jasonrhodes and others added 11 commits October 18, 2018 14:28

[APM] Distributed tracing - Trace details (waterfall) (#22763)

0f7e708

[APM] Add typescript to waterfall (#23635)

a1645d7

[APM] Migrate get_trace and constants to Typescript (#23634)

40473a8

Bump lock files

db00699

[APM] Add types for setup_request (#23762)

066f8d2

[APM] Adds trace overview queries and some refactoring (#23605)

0e9ddce

Refactoring includes: * ImpactBar component to align EuiProgress usage for impact bars * Sharing some logic between transaction and trace queries * Typescript support

Quick fix ‘banana’

977de9d

[APM] Ensure backwards compatibility for v1 and v2 (#23636)

921c282

Fix tests Make interfaces versioned Fix ts issues Rename eventType to docType WIP Working prototype Fix tests Limit get_transaction by trace.id

Fixes trace links on traces overview (#24089)

3474565

[APM] use react-redux-request (#24117)

6656f99

* [APM] use react-redux-request * Stricter type checking

sorenlouv force-pushed the apm/dt branch from ecf19c9 to 6656f99 Compare October 18, 2018 12:45

Bump yarn lock files

15cc220

Fix package.json

4e4544c

Updated yarn lockfile for new yarn version

de4bfe6

Updated dependency issues for react-router-dom types

cb3c28e

sorenlouv commented Oct 18, 2018

View reviewed changes

[APM] Display transaction info on span flyout (#24189)

4d01d0b

* [APM] Display transaction info on span flyout * Add links * Fix tests * Eui fixes * Remove color from span type

Fix failing tests

2b9e288

sorenlouv added 2 commits October 22, 2018 19:18

[APM] Minor docs cleanup (#24325)

0b35ebe

* [APM] Minor docs cleanup * Fix tests * Make `text` required * Simplify documentation module * Break docs into separate files * Remove `translateAgentName` method * Formatting

Merge branch 'master' of github.com:elastic/kibana into apm/dt

1c65a40

[APM] Fix issues with v1 spans (#24332)

0296faf

sorenlouv and others added 4 commits October 23, 2018 18:00

[APM] Add agent marks (#24361)

1095893

Typescript migration for the transaction endpoints (#24397)

994d566

Merge remote-tracking branch 'upstream/master' into apm/dt

4a3d5ab

sorenlouv commented Oct 23, 2018

View reviewed changes

jasonrhodes merged commit 3151da2 into master Oct 23, 2018

jasonrhodes mentioned this pull request Oct 23, 2018

Distributed tracing #24446

Merged

sorenlouv commented Oct 23, 2018

View reviewed changes

x-pack/plugins/apm/typings/Transaction.ts

pid: number;

};

service: ContextService;

system: ContextSystem;

Copy link

Member Author

sorenlouv Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional

sorenlouv commented Oct 23, 2018

View reviewed changes

sorenlouv mentioned this pull request Oct 24, 2018

[6.x] [APM] Distributed Tracing (#24062) #24487

Merged

sorenlouv deleted the apm/dt branch October 25, 2018 08:10

sorenlouv restored the apm/dt branch October 25, 2018 08:10

sorenlouv deleted the apm/dt branch October 25, 2018 08:11

sorenlouv mentioned this pull request Feb 21, 2019

[APM] Moving the date picker into APM #31311

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Distributed Tracing #24062

[APM] Distributed Tracing #24062

sorenlouv commented Oct 16, 2018

elasticmachine commented Oct 16, 2018

elasticmachine commented Oct 16, 2018

elasticmachine commented Oct 16, 2018

elasticmachine commented Oct 17, 2018

elasticmachine commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

sorenlouv Oct 18, 2018 •

edited

Loading

jasonrhodes Oct 19, 2018

elasticmachine commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 22, 2018

elasticmachine commented Oct 22, 2018

elasticmachine commented Oct 23, 2018

sorenlouv commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

sorenlouv Oct 23, 2018

sorenlouv Oct 23, 2018

jasonrhodes Oct 23, 2018

sorenlouv Oct 23, 2018 •

edited

Loading

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

sorenlouv Oct 23, 2018

sorenlouv Oct 23, 2018

	const formatted = numeral(value).format('0.0');
	const formatted = asInteger(value);

[APM] Distributed Tracing #24062

[APM] Distributed Tracing #24062

Conversation

sorenlouv commented Oct 16, 2018

elasticmachine commented Oct 16, 2018

💚 Build Succeeded

elasticmachine commented Oct 16, 2018

💚 Build Succeeded

elasticmachine commented Oct 16, 2018

💚 Build Succeeded

elasticmachine commented Oct 17, 2018

💔 Build Failed

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 18, 2018

💔 Build Failed

sorenlouv Oct 18, 2018 • edited Loading

Choose a reason for hiding this comment

jasonrhodes Oct 19, 2018

Choose a reason for hiding this comment

elasticmachine commented Oct 18, 2018

💚 Build Succeeded

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💚 Build Succeeded

elasticmachine commented Oct 19, 2018

💚 Build Succeeded

elasticmachine commented Oct 19, 2018

💚 Build Succeeded

elasticmachine commented Oct 22, 2018

💚 Build Succeeded

elasticmachine commented Oct 22, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

sorenlouv commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

sorenlouv Oct 23, 2018

Choose a reason for hiding this comment

sorenlouv Oct 23, 2018

Choose a reason for hiding this comment

jasonrhodes Oct 23, 2018

Choose a reason for hiding this comment

sorenlouv Oct 23, 2018 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

sorenlouv Oct 23, 2018

Choose a reason for hiding this comment

sorenlouv Oct 23, 2018

Choose a reason for hiding this comment

sorenlouv Oct 18, 2018 •

edited

Loading

sorenlouv Oct 23, 2018 •

edited

Loading