[APM] Add types for setup_request

[sorenlouv]

Adding types to setup_request, so doing something like this:

export async function getTrace(traceId: string, setup: Setup) {
  const { start, end, client, config } = setup;
  ...
}

Will provide intellisense and types for start, end, client and config.

[sorenlouv]

I would like to re-use the types from line 29:

https://github.com/elastic/kibana/blob/59734da6baadfe2c087e78865045c30ed2f17c79/x-pack/plugins/apm/server/lib/helpers/setup_request.ts#L29

But not sure how.

[jasonrhodes]

Does this work?

const client: Client<any> = (type, params) => {
  if (req.query._debug) {
    console.log(`DEBUG ES QUERY:`);
    console.log(
      `${req.method.toUpperCase()} ${req.url.pathname} ${JSON.stringify(
        req.query
      )}`
    );
    console.log(`GET ${params.index}/_search`);
    console.log(JSON.stringify(params.body, null, 4));
  }
  return cluster.callWithRequest(req, type, params);
};

[sorenlouv]

Yes, neat! Only drawback is that it doesn't allow us to narrow down the generic argument, so the return value will always be any. I'll leave as-is for now, and maybe we'll find a better solution.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[jasonrhodes]

Default param? Had no idea you could do that!

[jasonrhodes]

Had a suggestion for you re: a question you had about re-using the client type.

LGTM.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request