[6.x] Upgrade typescript to 2.9.2 (#20757) #20865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades TypeScript to version 2.9.2. My main motivation is the support for generic type arguments in JSX elements and tagged templates (e.g. for `styled-components`). Problems arising from breaking changes in the new TypeScript version have been mitigated by: * setting the `keyofStringsOnly` option until impacted code has been future-proofed * Restricting some joi-related generics See the [release notes](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html) for details. Some follow-up tasks should be: * Update EUI to support the new `keyof` behaviour * Update new platform TypeScript code to support new `keyof` behaviour * Remove `keyofStringsOnly` setting
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: