Upgrade typescript to 2.9.2 #20757
Merged
Upgrade typescript to 2.9.2 #20757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
weltenwort
force-pushed
the
enhancement-upgrade-typescript-2-9-2
branch
from
6b5af5b to
0c41656
Compare
💚 Build Succeeded |
azasypkin
reviewed
Jul 16, 2018
| "forceConsistentCasingInFileNames": true | ||
| "forceConsistentCasingInFileNames": true, | ||
|
|
||
| // Disable the breaking keyof behaviour introduced in TS 2.9.2 until EUI is updated to support that too |
There was a problem hiding this comment.
question: could you please file an issue in eui repo for that?
There was a problem hiding this comment.
certainly: elastic/eui#1016
| @@ -146,7 +147,7 @@ function siblingRef<T>(key: string): SiblingReference<T> { | |||
| return new SiblingReference(key); | |||
| } | |||
|
|
|||
| function conditional<A, B, C>( | |||
| function conditional<A extends SchemaLike, B, C>( | |||
There was a problem hiding this comment.
issue: hmm, I don't really like the signature of SchemaLike: string | number | boolean | object | null | Schema | SchemaMap since it exposes internal Schema and SchemaMap to the outside.
At this stage I'd rather prefer if we have something like export type ConditionalTypeValue = string | number | boolean | object | null; inside of conditional_type.ts that is re-exported in src/core/server/config/schema/types/index.ts and used here.
What do you think @weltenwort ?
There was a problem hiding this comment.
Good catch, fixed in the latest commit - thanks!
azasypkin
approved these changes
Jul 16, 2018
💚 Build Succeeded |
This resolves problems arising from breaking changes in the new TypeScript version by... * setting the `keyofStringsOnly` option until impacted code has been future-proofed * Restricting some joi-related generics
weltenwort
force-pushed
the
enhancement-upgrade-typescript-2-9-2
branch
from
518ccb7 to
d3aa6b5
Compare
💚 Build Succeeded |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Jul 16, 2018
This upgrades TypeScript to version 2.9.2. My main motivation is the support for generic type arguments in JSX elements and tagged templates (e.g. for `styled-components`). Problems arising from breaking changes in the new TypeScript version have been mitigated by: * setting the `keyofStringsOnly` option until impacted code has been future-proofed * Restricting some joi-related generics See the [release notes](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html) for details. Some follow-up tasks should be: * Update EUI to support the new `keyof` behaviour * Update new platform TypeScript code to support new `keyof` behaviour * Remove `keyofStringsOnly` setting
weltenwort
added a commit
that referenced
this pull request
Jul 17, 2018
This upgrades TypeScript to version 2.9.2. My main motivation is the support for generic type arguments in JSX elements and tagged templates (e.g. for `styled-components`). Problems arising from breaking changes in the new TypeScript version have been mitigated by: * setting the `keyofStringsOnly` option until impacted code has been future-proofed * Restricting some joi-related generics See the [release notes](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html) for details. Some follow-up tasks should be: * Update EUI to support the new `keyof` behaviour * Update new platform TypeScript code to support new `keyof` behaviour * Remove `keyofStringsOnly` setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades TypeScript to version 2.9.2. My main motivation is the support for generic type arguments in JSX elements and tagged templates (e.g. for
styled-components).Problems arising from breaking changes in the new TypeScript version have been mitigated by:
keyofStringsOnlyoption until impacted code has beenfuture-proofed
See the release notes for details.
Some follow-up tasks should be:
keyofbehaviourkeyofbehaviourkeyofStringsOnlysetting