Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Spaces] Remove “identifier” column from Spaces listing (#201290) #203164

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

tsullivan
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Addresses:
elastic/kibana-team#1241
Closes: elastic#195590

### Changes
1. Remove the "identifier" column from the Spaces grid listing
1. Add a readonly text field to the Space edit form to allow users to
see the identifier
2. Remove granular width adjustments from the "Description" and
"Solution view" columns to avoid header titles from showing ellipses

### Screenshots
**Spaces listing, before:**
<img width="2102" alt="image"
src="https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70">

**Spaces listing, after:**
<img width="2102" alt="image"
src="https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15">

**Spaces edit form, before**
<img width="2102" alt="image"
src="https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53">

**Spaces edit form, after**
<img width="2102" alt="image"
src="https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2">

(cherry picked from commit 7a2edb4)
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 256.8KB 256.7KB -167.0B

@tsullivan tsullivan requested a review from a team December 9, 2024 02:11
@tsullivan tsullivan merged commit bb08df0 into elastic:8.x Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants