[Spaces] Remove “identifier” column from Spaces listing #201290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
SiddharthMantri
approved these changes
Nov 26, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12041114985 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
4 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 5, 2024
## Summary Addresses: elastic/kibana-team#1241 Closes: elastic#195590 ### Changes 1. Remove the "identifier" column from the Spaces grid listing 1. Add a readonly text field to the Space edit form to allow users to see the identifier 2. Remove granular width adjustments from the "Description" and "Solution view" columns to avoid header titles from showing ellipses ### Screenshots **Spaces listing, before:** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70"> **Spaces listing, after:** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15"> **Spaces edit form, before** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53"> **Spaces edit form, after** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2"> (cherry picked from commit 7a2edb4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
tsullivan
added a commit
that referenced
this pull request
Dec 9, 2024
… (#203164) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces] Remove “identifier” column from Spaces listing (#201290)](#201290) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T00:03:49Z","message":"[Spaces] Remove “identifier” column from Spaces listing (#201290)\n\n## Summary\r\n\r\nAddresses:\r\nhttps://github.com/elastic/kibana-team/issues/1241?reload=1#top\r\nCloses: https://github.com/elastic/kibana/issues/195590\r\n\r\n### Changes\r\n1. Remove the \"identifier\" column from the Spaces grid listing\r\n1. Add a readonly text field to the Space edit form to allow users to\r\nsee the identifier\r\n2. Remove granular width adjustments from the \"Description\" and\r\n\"Solution view\" columns to avoid header titles from showing ellipses\r\n\r\n### Screenshots\r\n**Spaces listing, before:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70\">\r\n\r\n**Spaces listing, after:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15\">\r\n\r\n**Spaces edit form, before**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53\">\r\n\r\n**Spaces edit form, after**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2\">","sha":"7a2edb4811dad4aec91a7a195cd1e51cd5b49a32","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport missing","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":201290,"url":"https://github.com/elastic/kibana/pull/201290","mergeCommit":{"message":"[Spaces] Remove “identifier” column from Spaces listing (#201290)\n\n## Summary\r\n\r\nAddresses:\r\nhttps://github.com/elastic/kibana-team/issues/1241?reload=1#top\r\nCloses: https://github.com/elastic/kibana/issues/195590\r\n\r\n### Changes\r\n1. Remove the \"identifier\" column from the Spaces grid listing\r\n1. Add a readonly text field to the Space edit form to allow users to\r\nsee the identifier\r\n2. Remove granular width adjustments from the \"Description\" and\r\n\"Solution view\" columns to avoid header titles from showing ellipses\r\n\r\n### Screenshots\r\n**Spaces listing, before:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70\">\r\n\r\n**Spaces listing, after:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15\">\r\n\r\n**Spaces edit form, before**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53\">\r\n\r\n**Spaces edit form, after**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2\">","sha":"7a2edb4811dad4aec91a7a195cd1e51cd5b49a32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201290","number":201290,"mergeCommit":{"message":"[Spaces] Remove “identifier” column from Spaces listing (#201290)\n\n## Summary\r\n\r\nAddresses:\r\nhttps://github.com/elastic/kibana-team/issues/1241?reload=1#top\r\nCloses: https://github.com/elastic/kibana/issues/195590\r\n\r\n### Changes\r\n1. Remove the \"identifier\" column from the Spaces grid listing\r\n1. Add a readonly text field to the Space edit form to allow users to\r\nsee the identifier\r\n2. Remove granular width adjustments from the \"Description\" and\r\n\"Solution view\" columns to avoid header titles from showing ellipses\r\n\r\n### Screenshots\r\n**Spaces listing, before:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70\">\r\n\r\n**Spaces listing, after:**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15\">\r\n\r\n**Spaces edit form, before**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53\">\r\n\r\n**Spaces edit form, after**\r\n<img width=\"2102\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2\">","sha":"7a2edb4811dad4aec91a7a195cd1e51cd5b49a32"}}]}] BACKPORT-->
kibanamachine
added
v8.18.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Addresses: elastic/kibana-team#1241 Closes: elastic#195590 ### Changes 1. Remove the "identifier" column from the Spaces grid listing 1. Add a readonly text field to the Space edit form to allow users to see the identifier 2. Remove granular width adjustments from the "Description" and "Solution view" columns to avoid header titles from showing ellipses ### Screenshots **Spaces listing, before:** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/7bc5a8d1-d9c2-4e03-af9b-1bf9025f2d70"> **Spaces listing, after:** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/6f69b2cf-c381-43be-a6fd-e294f58b3f15"> **Spaces edit form, before** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/a622695f-400c-436c-9cbd-c110d83d3a53"> **Spaces edit form, after** <img width="2102" alt="image" src="https://github.com/user-attachments/assets/d5f2fd3f-ec4b-49c8-aece-a5b10dec37b2">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://github.com/elastic/kibana-team/issues/1241?reload=1#top
Closes: #195590
Changes
Screenshots
Spaces listing, before:
Spaces listing, after:
Spaces edit form, before
Spaces edit form, after
