[dashboard] Do not reset panel to undefined or empty last saved state #203158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Dec 9, 2024
| @@ -11,7 +11,7 @@ import { PublishingSubject } from '../publishing_subject'; | |||
|
|
|||
| export interface PublishesUnsavedChanges<Runtime extends object = object> { | |||
| unsavedChanges: PublishingSubject<Partial<Runtime> | undefined>; | |||
| resetUnsavedChanges: () => void; | |||
| resetUnsavedChanges: () => boolean; | |||
There was a problem hiding this comment.
Do you think we should remove this typing after the architectural fix is in? I think this should be temporary because in theory, the reset function shouldn't be capable of failing.
There was a problem hiding this comment.
agreed. This typing fix is only temporary.
| if (apiPublishesUnsavedChanges(child)) { | ||
| const success = child.resetUnsavedChanges(); | ||
| if (!success) { | ||
| coreServices.notifications.toasts.addWarning( |
There was a problem hiding this comment.
Great to have a warning in this case. I wonder if we should clarify that the user needs to start a new session (open a new tab etc) to get their last saved state back?
There was a problem hiding this comment.
I did not want to complicate the error message. Its complex because if its a by-ref panel then a new session will not revert the changes because the by-ref saved object has already been saved
There was a problem hiding this comment.
because the by-ref saved object has already been saved
Yet another example of why we need to fix this architecturally, as save and return on a by reference panel shouldn't even show unsaved changes on the Dashboard.
++ to not complicating the error message. Ideally this isn't seen by users at all.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
There are no new commits on the base branch. |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12248576609 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…elastic#203158) Part of elastic#201627 This is a short term fix for serverless and 8.x branches (long term fix is an architectural change that will only be merged into 9.0 and 8.18 branches). Fix prevents users from reseting a panel edited via embeddable transfer service. This prevents panel from getting into an invalid state. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit e103a25)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…elastic#203158) Part of elastic#201627 This is a short term fix for serverless and 8.x branches (long term fix is an architectural change that will only be merged into 9.0 and 8.18 branches). Fix prevents users from reseting a panel edited via embeddable transfer service. This prevents panel from getting into an invalid state. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit e103a25)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…elastic#203158) Part of elastic#201627 This is a short term fix for serverless and 8.x branches (long term fix is an architectural change that will only be merged into 9.0 and 8.18 branches). Fix prevents users from reseting a panel edited via embeddable transfer service. This prevents panel from getting into an invalid state. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit e103a25)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…d state (#203158) (#203511) # Backport This will backport the following commits from `main` to `8.17`: - [[dashboard] Do not reset panel to undefined or empty last saved state (#203158)](#203158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T03:04:15Z","message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0","v8.16.2","v8.15.6","v8.17.1"],"title":"[dashboard] Do not reset panel to undefined or empty last saved state","number":203158,"url":"https://github.com/elastic/kibana/pull/203158","mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.15","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203158","number":203158,"mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
… state (#203158) (#203512) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] Do not reset panel to undefined or empty last saved state (#203158)](#203158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T03:04:15Z","message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0","v8.16.2","v8.15.6","v8.17.1"],"title":"[dashboard] Do not reset panel to undefined or empty last saved state","number":203158,"url":"https://github.com/elastic/kibana/pull/203158","mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.15","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203158","number":203158,"mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…d state (#203158) (#203510) # Backport This will backport the following commits from `main` to `8.16`: - [[dashboard] Do not reset panel to undefined or empty last saved state (#203158)](#203158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T03:04:15Z","message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0","v8.16.2","v8.15.6","v8.17.1"],"title":"[dashboard] Do not reset panel to undefined or empty last saved state","number":203158,"url":"https://github.com/elastic/kibana/pull/203158","mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.15","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203158","number":203158,"mergeCommit":{"message":"[dashboard] Do not reset panel to undefined or empty last saved state (#203158)\n\nPart of https://github.com/elastic/kibana/issues/201627\r\n\r\nThis is a short term fix for serverless and 8.x branches (long term fix\r\nis an architectural change that will only be merged into 9.0 and 8.18\r\nbranches).\r\n\r\nFix prevents users from reseting a panel edited via embeddable transfer\r\nservice. This prevents panel from getting into an invalid state.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e103a253d9b756605dbeb92955ff517597055970"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
This was referenced Dec 10, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#203158) Part of elastic#201627 This is a short term fix for serverless and 8.x branches (long term fix is an architectural change that will only be merged into 9.0 and 8.18 branches). Fix prevents users from reseting a panel edited via embeddable transfer service. This prevents panel from getting into an invalid state. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #201627
This is a short term fix for serverless and 8.x branches (long term fix is an architectural change that will only be merged into 9.0 and 8.18 branches).
Fix prevents users from reseting a panel edited via embeddable transfer service. This prevents panel from getting into an invalid state.