Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Show existing data callout in Firehose flow #203072

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Dec 5, 2024

Closes #190795

Adds the logic to display a message to the user in case there is already an existing Firehose data in their cluster and to show the identified AWS services in the "Visualize Data" step right away without waiting for the window to loose focus first.

CleanShot 2024-12-05 at 11 50 59@2x

How to test

  1. Open the Firehose flow
  2. Make sure there is no callout and the third step is not active
  3. Go to Kibana dev console and ingest some dummy data (see examples bellow)
  4. Refresh the page with the Firehose flow
  5. make sure there is a callout and the third steps shows the identified AWS service
POST logs-aws.apigateway_logs-default/_doc
{
  "@timestamp": "2024-11-25T13:32:01.000Z",
  "some": 111,
  "aws.kinesis.name": "Elastic-CloudwatchLogs"
}

POST metrics-aws.apigateway_metrics-default/_doc
{
    "@timestamp": "2024-11-25T13:31:01.000Z",
    "agent": {
      "type": "firehose"
    },
    "aws": {
      "cloudwatch": {
        "namespace": "AWS/ApiGateway"
      },
      "exporter": {
        "arn": "arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J"
      }
    },
    "cloud": {
      "account": {
        "id": "975050175126"
      },
      "provider": "aws",
      "region": "us-west-2"
    }
}

@mykolaharmash mykolaharmash requested review from a team as code owners December 5, 2024 10:52
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mykolaharmash mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development Team:obs-ux-logs Observability Logs User Experience Team Feature: Observability Onboarding labels Dec 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-onboarding-team (Feature: Observability Onboarding)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs UI LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 6, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 0c5ce53
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203072-0c5ce5371f98

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 253 255 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 272.1KB 273.1KB +966.0B

History

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 9, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 1a3bf2d
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203072-1a3bf2d8faa4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 253 255 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 272.4KB 273.3KB +966.0B

History

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as described and it worked fine - left one question

return callApi('GET /internal/observability_onboarding/firehose/has-data', {
params: {
query: {
logsStreamName: FIREHOSE_LOGS_STREAM_NAME,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only checking for cloudwatch logs - are we sure those will always exist if the user went through the flow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch, thank you! The split in two streams came later and I forgot to update this endpoint. Though, with the latest template there will again be only one stream, I've created a follow up task to use the latest template and adopt the code to use a single firehose stream.

@mykolaharmash mykolaharmash merged commit 6cb1430 into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12256747990

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
elastic#203072)

Closes elastic#190795

Adds the logic to display a message to the user in case there is already
an existing Firehose data in their cluster and to show the identified
AWS services in the "Visualize Data" step right away without waiting for
the window to loose focus first.

![CleanShot 2024-12-05 at 11 50
59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)

## How to test

1. Open the Firehose flow
2. Make sure there is no callout and the third step is not active
3. Go to Kibana dev console and ingest some dummy data (see examples
bellow)
4. Refresh the page with the Firehose flow
5. make sure there is a callout and the third steps shows the identified
AWS service

```
POST logs-aws.apigateway_logs-default/_doc
{
  "@timestamp": "2024-11-25T13:32:01.000Z",
  "some": 111,
  "aws.kinesis.name": "Elastic-CloudwatchLogs"
}

POST metrics-aws.apigateway_metrics-default/_doc
{
    "@timestamp": "2024-11-25T13:31:01.000Z",
    "agent": {
      "type": "firehose"
    },
    "aws": {
      "cloudwatch": {
        "namespace": "AWS/ApiGateway"
      },
      "exporter": {
        "arn": "arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J"
      }
    },
    "cloud": {
      "account": {
        "id": "975050175126"
      },
      "provider": "aws",
      "region": "us-west-2"
    }
}
```

(cherry picked from commit 6cb1430)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
elastic#203072)

Closes elastic#190795

Adds the logic to display a message to the user in case there is already
an existing Firehose data in their cluster and to show the identified
AWS services in the "Visualize Data" step right away without waiting for
the window to loose focus first.

![CleanShot 2024-12-05 at 11 50
59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)

## How to test

1. Open the Firehose flow
2. Make sure there is no callout and the third step is not active
3. Go to Kibana dev console and ingest some dummy data (see examples
bellow)
4. Refresh the page with the Firehose flow
5. make sure there is a callout and the third steps shows the identified
AWS service

```
POST logs-aws.apigateway_logs-default/_doc
{
  "@timestamp": "2024-11-25T13:32:01.000Z",
  "some": 111,
  "aws.kinesis.name": "Elastic-CloudwatchLogs"
}

POST metrics-aws.apigateway_metrics-default/_doc
{
    "@timestamp": "2024-11-25T13:31:01.000Z",
    "agent": {
      "type": "firehose"
    },
    "aws": {
      "cloudwatch": {
        "namespace": "AWS/ApiGateway"
      },
      "exporter": {
        "arn": "arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J"
      }
    },
    "cloud": {
      "account": {
        "id": "975050175126"
      },
      "provider": "aws",
      "region": "us-west-2"
    }
}
```

(cherry picked from commit 6cb1430)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
elastic#203072)

Closes elastic#190795

Adds the logic to display a message to the user in case there is already
an existing Firehose data in their cluster and to show the identified
AWS services in the "Visualize Data" step right away without waiting for
the window to loose focus first.

![CleanShot 2024-12-05 at 11 50
59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)

## How to test

1. Open the Firehose flow
2. Make sure there is no callout and the third step is not active
3. Go to Kibana dev console and ingest some dummy data (see examples
bellow)
4. Refresh the page with the Firehose flow
5. make sure there is a callout and the third steps shows the identified
AWS service

```
POST logs-aws.apigateway_logs-default/_doc
{
  "@timestamp": "2024-11-25T13:32:01.000Z",
  "some": 111,
  "aws.kinesis.name": "Elastic-CloudwatchLogs"
}

POST metrics-aws.apigateway_metrics-default/_doc
{
    "@timestamp": "2024-11-25T13:31:01.000Z",
    "agent": {
      "type": "firehose"
    },
    "aws": {
      "cloudwatch": {
        "namespace": "AWS/ApiGateway"
      },
      "exporter": {
        "arn": "arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J"
      }
    },
    "cloud": {
      "account": {
        "id": "975050175126"
      },
      "provider": "aws",
      "region": "us-west-2"
    }
}
```

(cherry picked from commit 6cb1430)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Session management] update cleanup query to allow partial search results for PIT query (#203413)
- [dashboard] Do not reset panel to undefined or empty last saved state (#203158)
8.16
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 203072

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
…ose flow (#203072) (#203566)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Observability Onboarding] Show existing data callout in Firehose
flow (#203072)](#203072)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T13:07:11Z","message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-logs","Feature:
Observability Onboarding"],"title":"[Observability Onboarding] Show
existing data callout in Firehose
flow","number":203072,"url":"https://github.com/elastic/kibana/pull/203072","mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203072","number":203072,"mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 10, 2024
…ose flow (#203072) (#203565)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Observability Onboarding] Show existing data callout in Firehose
flow (#203072)](#203072)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T13:07:11Z","message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-logs","Feature:
Observability Onboarding"],"title":"[Observability Onboarding] Show
existing data callout in Firehose
flow","number":203072,"url":"https://github.com/elastic/kibana/pull/203072","mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203072","number":203072,"mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 10, 2024
…se flow (#203072) (#203567)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability Onboarding] Show existing data callout in Firehose
flow (#203072)](#203072)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T13:07:11Z","message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-logs","Feature:
Observability Onboarding"],"title":"[Observability Onboarding] Show
existing data callout in Firehose
flow","number":203072,"url":"https://github.com/elastic/kibana/pull/203072","mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203072","number":203072,"mergeCommit":{"message":"[Observability
Onboarding] Show existing data callout in Firehose flow
(#203072)\n\nCloses
https://github.com/elastic/kibana/issues/190795\r\n\r\nAdds the logic to
display a message to the user in case there is already\r\nan existing
Firehose data in their cluster and to show the identified\r\nAWS
services in the \"Visualize Data\" step right away without waiting
for\r\nthe window to loose focus first.\r\n\r\n![CleanShot 2024-12-05 at
11
50\r\n59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)\r\n\r\n\r\n##
How to test\r\n\r\n1. Open the Firehose flow\r\n2. Make sure there is no
callout and the third step is not active\r\n3. Go to Kibana dev console
and ingest some dummy data (see examples\r\nbellow)\r\n4. Refresh the
page with the Firehose flow\r\n5. make sure there is a callout and the
third steps shows the identified\r\nAWS service\r\n\r\n```\r\nPOST
logs-aws.apigateway_logs-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:32:01.000Z\",\r\n \"some\": 111,\r\n
\"aws.kinesis.name\": \"Elastic-CloudwatchLogs\"\r\n}\r\n\r\nPOST
metrics-aws.apigateway_metrics-default/_doc\r\n{\r\n \"@timestamp\":
\"2024-11-25T13:31:01.000Z\",\r\n \"agent\": {\r\n \"type\":
\"firehose\"\r\n },\r\n \"aws\": {\r\n \"cloudwatch\": {\r\n
\"namespace\": \"AWS/ApiGateway\"\r\n },\r\n \"exporter\": {\r\n
\"arn\":
\"arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J\"\r\n
}\r\n },\r\n \"cloud\": {\r\n \"account\": {\r\n \"id\":
\"975050175126\"\r\n },\r\n \"provider\": \"aws\",\r\n \"region\":
\"us-west-2\"\r\n
}\r\n}\r\n```","sha":"6cb14302a1a3fd157d1e1947493a0d0d5f4980f6"}}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
elastic#203072)

Closes elastic#190795

Adds the logic to display a message to the user in case there is already
an existing Firehose data in their cluster and to show the identified
AWS services in the "Visualize Data" step right away without waiting for
the window to loose focus first.

![CleanShot 2024-12-05 at 11 50
59@2x](https://github.com/user-attachments/assets/00653bf0-f711-4029-9011-a34a160b4b9b)


## How to test

1. Open the Firehose flow
2. Make sure there is no callout and the third step is not active
3. Go to Kibana dev console and ingest some dummy data (see examples
bellow)
4. Refresh the page with the Firehose flow
5. make sure there is a callout and the third steps shows the identified
AWS service

```
POST logs-aws.apigateway_logs-default/_doc
{
  "@timestamp": "2024-11-25T13:32:01.000Z",
  "some": 111,
  "aws.kinesis.name": "Elastic-CloudwatchLogs"
}

POST metrics-aws.apigateway_metrics-default/_doc
{
    "@timestamp": "2024-11-25T13:31:01.000Z",
    "agent": {
      "type": "firehose"
    },
    "aws": {
      "cloudwatch": {
        "namespace": "AWS/ApiGateway"
      },
      "exporter": {
        "arn": "arn:aws:cloudwatch:us-west-2:975050175126:metric-stream/Elastic-CloudwatchLogsAndMetricsToFirehose-CloudWatchMetricStream-Nhb4NhzPdL4J"
      }
    },
    "cloud": {
      "account": {
        "id": "975050175126"
      },
      "provider": "aws",
      "region": "us-west-2"
    }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project Feature: Observability Onboarding release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Onboarding] Identify existing data
5 participants