[ALERTING][APM] Fix service names with spaces are not being URL encoded properly for {{context.viewInAppUrl}} #202890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for {{context.viewInAppUrl}}
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
fkanout
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
fkanout
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
Historycc @fkanout |
botelastic
bot
added
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12160254032 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
(cherry picked from commit 12133a0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ed properly for {{context.viewInAppUrl}} (elastic#202890)
## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2024
… encoded properly for {{context.viewInAppUrl}} (#202890) (#202911)
# Backport
This will backport the following commits from `main` to `8.x`:
- [[ALERTING][APM] Fix service names with spaces are not being URL
encoded properly for {{context.viewInAppUrl}}
(#202890)](#202890)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Faisal
Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T12:59:14Z","message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"title":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
","number":202890,"url":"https://github.com/elastic/kibana/pull/202890","mergeCommit":{"message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202890","number":202890,"mergeCommit":{"message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873"}}]}] BACKPORT-->
Co-authored-by: Faisal Kanout <[email protected]>
Co-authored-by: Irene Blanco <[email protected]>
kibanamachine
added
v8.18.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #184381 by encoding correctly the service name and adding tests