Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service names with spaces are not being URL encoded properly for {{context.viewInAppUrl}} #184381

Closed
simianhacker opened this issue May 28, 2024 · 1 comment · Fixed by #202890
Closed

[APM] Service names with spaces are not being URL encoded properly for {{context.viewInAppUrl}} #184381

simianhacker opened this issue May 28, 2024 · 1 comment · Fixed by #202890
Assignees
@fkanout
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team

Comments

@simianhacker
Copy link
Member

Kibana version:

8.13.2

Elasticsearch version:

8.13.2

Describe the bug:

When an APM service name contains a space, the {{context.viewInAppUrl}} is not properly encoded.

Steps to reproduce:

  1. Create an APM service with a space in it
  2. Create an APM specific alert that will trigger
  3. Create an action that uses {{context.viewInAppUrl}}

Expected behavior:

The space in the service.name should be encoded.

Any additional context:

service.name in this file should be wrapped with encodeURIComponent:

kibana/x-pack/plugins/observability_solution/apm/common/utils/formatters/alert_url.ts

Line 16 in 5a74376

pathname: `/app/apm/services/${serviceName}/errors`,

and here:

kibana/x-pack/plugins/observability_solution/apm/common/utils/formatters/alert_url.ts

Line 28 in 5a74376

pathname: `/app/apm/services/${serviceName}`,

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team labels May 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout self-assigned this Dec 3, 2024
@fkanout fkanout mentioned this issue Dec 4, 2024
Merged
@fkanout fkanout closed this as completed in 12133a0 Dec 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 4, 2024
@fkanout
[ALERTING][APM] Fix service names with spaces are not being URL encod…
c224de1 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests

(cherry picked from commit 12133a0)
hop-dev pushed a commit to hop-dev/kibana that referenced this issue Dec 5, 2024
@fkanout @hop-dev
[ALERTING][APM] Fix service names with spaces are not being URL encod…
40ea13b 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@fkanout @SoniaSanzV
[ALERTING][APM] Fix service names with spaces are not being URL encod…
7eced3f 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@fkanout @SoniaSanzV
[ALERTING][APM] Fix service names with spaces are not being URL encod…
b706afc 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@fkanout @CAWilson94
[ALERTING][APM] Fix service names with spaces are not being URL encod…
ecb125b 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@fkanout @CAWilson94
[ALERTING][APM] Fix service names with spaces are not being URL encod…
0380ac5 
…ed properly for {{context.viewInAppUrl}} (elastic#202890)

## Summary
It fixes elastic#184381 by encoding correctly the service name and adding tests
kibanamachine added a commit that referenced this issue Dec 17, 2024
@kibanamachine @fkanout @iblancof
[8.x] [ALERTING][APM] Fix service names with spaces are not being URL…
ab810a0 
… encoded properly for {{context.viewInAppUrl}} (#202890) (#202911)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ALERTING][APM] Fix service names with spaces are not being URL
encoded properly for {{context.viewInAppUrl}}
(#202890)](#202890)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Faisal
Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T12:59:14Z","message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"title":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
","number":202890,"url":"https://github.com/elastic/kibana/pull/202890","mergeCommit":{"message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202890","number":202890,"mergeCommit":{"message":"[ALERTING][APM]
Fix service names with spaces are not being URL encoded properly for
(#202890)\n\n## Summary\r\nIt fixes #184381 by encoding correctly the
service name and adding
tests","sha":"12133a0c7ac3462db9cb911cd9e1431b06c2d873"}}]}] BACKPORT-->

Co-authored-by: Faisal Kanout <[email protected]>
Co-authored-by: Irene Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkanout fkanout

Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@simianhacker @fkanout @elasticmachine