adding data-test-subj to buttons and updating snapshots #20080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
cjcenizal
approved these changes
Jun 20, 2018
| @@ -24,19 +24,19 @@ export class LicenseStatus extends React.PureComponent { | |||
| if (isExpired) { | |||
| icon = <EuiIcon color="danger" type="alert" />; | |||
| message = ( | |||
| <span> | |||
| <span data-test-subj="licenseSubText"> | |||
There was a problem hiding this comment.
It might make maintenance easier if we dedupe these three span elements by changing them to Fragments like this:
if (isExpired) {
icon = <EuiIcon color="danger" type="alert" />;
message = (
<Fragment>
Your license expired on <strong>{expiryDate}</strong>
</Fragment>
);
title = `Your ${type} license has expired`;
} else {
icon = <EuiIcon color="success" type="checkInCircleFilled" />;
message = expiryDate ? (
<Fragment>
Your license will expire on <strong>{expiryDate}</strong>
</Fragment>
) : (
<Fragment>
Your license will never expire.
</Fragment>
);
title = `Your ${type} license is ${status.toLowerCase()}`;
}And then instantiate the span itself on line 70 like this:
<EuiText color="subdued">
<span data-test-subj="licenseSubText">
{message}
</span>
</EuiText>
|
Don't forget version labels 🙂 |
|
Thx @jen-huang done. Wish this would happen in some automated fashion -- I will always forget to do this. |
💔 Build Failed |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Jun 20, 2018
* adding data-test-subj to buttons and updating snapshots * PR feedback * updating snapshots
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Jun 20, 2018
* adding data-test-subj to buttons and updating snapshots * PR feedback * updating snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19968. Adding data-test-subj attributes to support functional tests.