Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-test-subj attributes for License Management UI #19968

Closed
LeeDr opened this issue Jun 15, 2018 · 2 comments
Closed

Add data-test-subj attributes for License Management UI #19968

LeeDr opened this issue Jun 15, 2018 · 2 comments

Comments

@LeeDr
Copy link

LeeDr commented Jun 15, 2018

Describe the feature: Please add the following data-test-subj attributes to the License Management UI to enable functional testing.

Describe a specific use case for the feature: I'm working on these tests in a separate repo where the tests run in VMs and I can move the clock around for expiring licenses and can restore a snapshot to go through different scenarios, so we may not see many of these tests in this repo.

I'll suggest data-test-subj values but certainly open for discussion.

  1. data-test-subj="licenseText" We need to be able to check that this text shows the expected license
    image

  2. data-test-subj="licenseSubText" would be nice to also be able to check this subtext which shows when/if the license will expire
    image

  3. data-test-subj="updateLicenseButton"
    image

  4. data-test-subj="startTrialButton"
    image

  5. data-test-subj="revertToBasicButton"
    image

  6. data-test-subj="extendTrialButton"
    image

  7. data-test-subj="licenseFileUploadLink"
    image

  8. data-test-subj="licenseCancelUploadButton" and data-test-subj="licenseUploadButton"
    image

  9. These buttons already have data-test-subj's
    image

  10. data-test-subj="licenseUploadErrorText
    image

  11. These already have generic data-test-subjs confirmModalCancelButton and confirmModalConfirmButton
    image

@bmcconaghy
Copy link
Contributor

@LeeDr #7 is in EUI and not in control of the code for license management. I think selecting on input of type file should work for that as that is the only file input present.

@LeeDr
Copy link
Author

LeeDr commented Jun 20, 2018

@bmcconaghy I'm OK with that on #7. And/or I can file an issue in EUI to get a data-test-subj added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants