Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [Dataset Quality] Fix failing test on mki qa (#196122) #196816

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[8.16] [Dataset Quality] Fix failing test on mki qa (#196122) #196816

merged 2 commits into from
Oct 18, 2024

Conversation

achyutjhunjhunwala
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@achyutjhunjhunwala
[Dataset Quality] Fix failing test on mki qa (elastic#196122)
6cd118d 
## Summary

Closes elastic#195466

As LogDB mode is enabled on MKI QA environment, it causes mappings for
certain fields like `host.name` to be set differently. Hence causing
tests to fail.

As part of the fix, before ingesting data, i am statically setting the
mappings so that it does not cause any collision with something outside
the scope of the tests

(cherry picked from commit 7237902)

# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_field_analyze.ts
#	x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) October 18, 2024 08:43
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 18, 2024
@achyutjhunjhunwala achyutjhunjhunwala mentioned this pull request Oct 18, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 18, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 5a99fe2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196816-5a99fe2f646e

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/apm-synthtrace 64 69 +5
Unknown metric groups

API count

id before after diff
@kbn/apm-synthtrace 64 69 +5

History

@achyutjhunjhunwala achyutjhunjhunwala merged commit d7bbd0a into elastic:8.16 Oct 18, 2024
29 checks passed
@achyutjhunjhunwala achyutjhunjhunwala deleted the backport/8.16/pr-196122 branch October 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achyutjhunjhunwala @elasticmachine @yngrdyn