Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAILS ON MKI] Dataset quality Degraded field analyze gets limit analysis for a given datastream and degraded field should return default limits and should return isFieldLimitIssue as false #195466

Closed
wayneseymour opened this issue Oct 8, 2024 · 2 comments · Fixed by #196122
Closed

[FAILS ON MKI] Dataset quality Degraded field analyze gets limit analysis for a given datastream and degraded field should return default limits and should return isFieldLimitIssue as false #195466

wayneseymour opened this issue Oct 8, 2024 · 2 comments · Fixed by #196122
Assignees
@achyutjhunjhunwala
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-logs Observability Logs User Experience Team test-failure-flaky

Comments

@wayneseymour
Copy link
Member

wayneseymour commented Oct 8, 2024 •
edited
Loading

Summary

Multiple Files failing Repeatedly on MKI

Config

x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts

Test

Serverless Observability - Deployment-agnostic api integration tests Dataset quality Degraded field analyze gets limit analysis for a given datastream and degraded field should return default limits and should return isFieldLimitIssue as false

File

x-pack/test/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_field_analyze.ts

Error message

Error: expected 24 to equal 25
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context. (degraded_field_analyze.ts:99:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:74:16)

Config

x-pack/test_serverless/functional/test_suites/observability/config.ts

File

x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts

Test 1

serverless observability UI Dataset Quality Degraded fields flyout testing root cause for ignored fields field limit exceeded should display cause as "field limit exceeded" when a field is ignored due to field limit issue

Error message

Error: retry.tryForTime reached timeout 5000 ms
Error: expected false to equal true
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at degraded_field_flyout.ts:256:48
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runAttempt (retry_for_success.ts:30:15)
    at retryForSuccess (retry_for_success.ts:99:21)
    at RetryService.tryForTime (retry.ts:38:12)
    at Context. (degraded_field_flyout.ts:251:11)
    at Object.apply (wrap_function.js:74:16)
    at onFailure (retry_for_success.ts:18:9)
    at retryForSuccess (retry_for_success.ts:85:7)
    at RetryService.tryForTime (retry.ts:38:12)
    at Context. (degraded_field_flyout.ts:251:11)
    at Object.apply (wrap_function.js:74:16)

Screenshot

Image

Test 2

serverless observability UI Dataset Quality Degraded fields flyout testing root cause for ignored fields field limit exceeded should display the limit when the cause is "field limit exceeded"

Error message

Error: retry.tryForTime reached timeout 5000 ms
Error: expected false to equal true
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at degraded_field_flyout.ts:273:36
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runAttempt (retry_for_success.ts:30:15)
    at retryForSuccess (retry_for_success.ts:99:21)
    at RetryService.tryForTime (retry.ts:38:12)
    at Context. (degraded_field_flyout.ts:268:11)
    at Object.apply (wrap_function.js:74:16)
    at onFailure (retry_for_success.ts:18:9)
    at retryForSuccess (retry_for_success.ts:85:7)
    at RetryService.tryForTime (retry.ts:38:12)
    at Context. (degraded_field_flyout.ts:268:11)
    at Object.apply (wrap_function.js:74:16)

Screenshot

Image

Test 3

serverless observability UI Dataset Quality Degraded fields flyout testing root cause for ignored fields field limit exceeded should warn users about the issue not present in latest backing index

Error message

Error: expected testSubject(datasetQualityDetailsDegradedFieldFlyoutIssueDoesNotExist) to exist
    at TestSubjects.existOrFail (test_subjects.ts:76:13)
    at Context. (degraded_field_flyout.ts:285:11)
    at Object.apply (wrap_function.js:74:16)

Screenshot

Image

Test 4

serverless observability UI Dataset Quality Degraded fields flyout testing root cause for ignored fields current quality issues should close the flyout when current quality switch is toggled on and the flyout is already open with an old field

Error message

Error: expected testSubject(datasetQualityDetailsDegradedFieldFlyout) to exist
    at TestSubjects.existOrFail (test_subjects.ts:76:13)
    at Context. (degraded_field_flyout.ts:397:11)
    at Object.apply (wrap_function.js:74:16)

Screenshot

Image
@wayneseymour wayneseymour added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-logs Observability Logs User Experience Team test-failure-flaky labels Oct 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

wayneseymour added a commit to wayneseymour/kibana that referenced this issue Oct 9, 2024
@wayneseymour
[SKIP ON MKI] 2 Data Set Quality Files
c44a706 
details: elastic#195466
@wayneseymour wayneseymour mentioned this issue Oct 9, 2024
Merged
pheyos pushed a commit that referenced this issue Oct 9, 2024
@wayneseymour
[SKIP ON MKI] 2 Data Set Quality Files (#195554)
3618eca 
## Summary

details: #195466
@wayneseymour
Copy link
Member Author

Root Cause

#195554 (review)

@gbamparop gbamparop added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 14, 2024
@achyutjhunjhunwala achyutjhunjhunwala mentioned this issue Oct 14, 2024
Merged
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Oct 14, 2024
achyutjhunjhunwala added a commit that referenced this issue Oct 14, 2024
@achyutjhunjhunwala
[Dataset Quality] Fix failing test on mki qa (#196122)
7237902 
## Summary

Closes #195466

As LogDB mode is enabled on MKI QA environment, it causes mappings for
certain fields like `host.name` to be set differently. Hence causing
tests to fail.

As part of the fix, before ingesting data, i am statically setting the
mappings so that it does not cause any collision with something outside
the scope of the tests
achyutjhunjhunwala added a commit to achyutjhunjhunwala/kibana that referenced this issue Oct 18, 2024
@achyutjhunjhunwala
[Dataset Quality] Fix failing test on mki qa (elastic#196122)
6cd118d 
## Summary

Closes elastic#195466

As LogDB mode is enabled on MKI QA environment, it causes mappings for
certain fields like `host.name` to be set differently. Hence causing
tests to fail.

As part of the fix, before ingesting data, i am statically setting the
mappings so that it does not cause any collision with something outside
the scope of the tests

(cherry picked from commit 7237902)

# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_field_analyze.ts
#	x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
achyutjhunjhunwala added a commit to achyutjhunjhunwala/kibana that referenced this issue Oct 21, 2024
@achyutjhunjhunwala
[Dataset Quality] Fix failing test on mki qa (elastic#196122)
b9622ef 
## Summary

Closes elastic#195466

As LogDB mode is enabled on MKI QA environment, it causes mappings for
certain fields like `host.name` to be set differently. Hence causing
tests to fail.

As part of the fix, before ingesting data, i am statically setting the
mappings so that it does not cause any collision with something outside
the scope of the tests

(cherry picked from commit 7237902)

# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_field_analyze.ts
#	x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
achyutjhunjhunwala added a commit that referenced this issue Oct 23, 2024
@achyutjhunjhunwala
[8.x] [Dataset Quality] Fix failing test on mki qa (#196122) (#197072)
1785b76 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Fix failing test on mki qa
(#196122)](#196122)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Achyut
Jhunjhunwala","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T19:19:10Z","message":"[Dataset
Quality] Fix failing test on mki qa (#196122)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is
enabled on MKI QA environment, it causes mappings for\r\ncertain fields
like `host.name` to be set differently. Hence causing\r\ntests to
fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically
setting the\r\nmappings so that it does not cause any collision with
something outside\r\nthe scope of the
tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","Feature:Dataset
Health","apm:review","v8.16.0"],"number":196122,"url":"https://github.com/elastic/kibana/pull/196122","mergeCommit":{"message":"[Dataset
Quality] Fix failing test on mki qa (#196122)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is
enabled on MKI QA environment, it causes mappings for\r\ncertain fields
like `host.name` to be set differently. Hence causing\r\ntests to
fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically
setting the\r\nmappings so that it does not cause any collision with
something outside\r\nthe scope of the
tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196122","number":196122,"mergeCommit":{"message":"[Dataset
Quality] Fix failing test on mki qa (#196122)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is
enabled on MKI QA environment, it causes mappings for\r\ncertain fields
like `host.name` to be set differently. Hence causing\r\ntests to
fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically
setting the\r\nmappings so that it does not cause any collision with
something outside\r\nthe scope of the
tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/196816","number":196816,"branch":"8.16","state":"MERGED","mergeCommit":{"sha":"d7bbd0adf3108fc00dddf361bc4d7840ded5dc8f","message":"[8.16]
[Dataset Quality] Fix failing test on mki qa (#196122) (#196816)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.16`:\n- [[Dataset Quality] Fix failing test on mki
qa\n(#196122)](https://github.com/elastic/kibana/pull/196122)\n\n<!---
Backport version: 8.9.8 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Achyut\nJhunjhunwala\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-14T19:19:10Z\",\"message\":\"[Dataset\nQuality]
Fix failing test on mki qa
(#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs
LogDB mode is\nenabled on MKI QA environment, it causes mappings
for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence
causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before
ingesting data, i am statically\nsetting the\\r\\nmappings so that it
does not cause any collision with\nsomething outside\\r\\nthe scope of
the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport\nmissing\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-logs\",\"Team:obs-ux-infra_services\",\"Feature:Dataset\nHealth\",\"apm:review\"],\"number\":196122,\"url\":\"https://github.com/elastic/kibana/pull/196122\",\"mergeCommit\":{\"message\":\"[Dataset\nQuality]
Fix failing test on mki qa
(#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs
LogDB mode is\nenabled on MKI QA environment, it causes mappings
for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence
causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before
ingesting data, i am statically\nsetting the\\r\\nmappings so that it
does not cause any collision with\nsomething outside\\r\\nthe scope of
the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"labelRegex\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196122\",\"number\":196122,\"mergeCommit\":{\"message\":\"[Dataset\nQuality]
Fix failing test on mki qa
(#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs
LogDB mode is\nenabled on MKI QA environment, it causes mappings
for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence
causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before
ingesting data, i am statically\nsetting the\\r\\nmappings so that it
does not cause any collision with\nsomething outside\\r\\nthe scope of
the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\"}}]}]
BACKPORT-->"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:obs-ux-logs Observability Logs User Experience Team test-failure-flaky
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dataset Quality] Fix failing test on mki qa achyutjhunjhunwala/kibana
4 participants
@wayneseymour @gbamparop @achyutjhunjhunwala @elasticmachine