Remove dirty prompt from Logstash Pipeline Management #19649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar routing issue.
justinkambic
added
bug
|
cc @ycombinator |
💔 Build Failed |
liza-mae
approved these changes
Jun 4, 2018
💚 Build Succeeded |
justinkambic
added a commit
that referenced
this pull request
Jun 5, 2018
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue. * Remove test for removed feature.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jun 5, 2018
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue. * Remove test for removed feature.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jun 7, 2018
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue. * Remove test for removed feature.
justinkambic
added a commit
that referenced
this pull request
Jun 7, 2018
justinkambic
deleted the
bug-fix/remove-dirty-prompt-to-avoid-angular-infinite-digest-loop
branch
kindsun
pushed a commit
that referenced
this pull request
Jun 12, 2018
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue. * Remove test for removed feature.
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue. * Remove test for removed feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change is in response to an issue related to a dynamic URL routing issue originally referenced in #19594 and specifically #19608 for this instance of the issue. When the dirty prompt we're using on this page tries to stop the default navigation, it triggers an infinite digest loop like below:
As a temporary measure we're removing the dirty prompt, which appears to fix the issue.
Resolves #19608
Testing this PR
Create Pipeline View
Edit Pipeline View
Repeat steps 0-5 of the previous test.