Canceling an angular route causes infinite digest loop

[chrisronline]

We recently introduced this change that had an unintended side effect related to this issue.

We use a dirty prompt within Watcher to prompt the user if they have unsaved changes if they navigate away from the edit page. However, when we cancel the navigation event for the confirm prompt, we get this infinite digest loop.

My best guess is because we are no longer rewriting urls, we're hitting an issue on this line where the urls are close but one is encoded and the other is not so they technically do not match and this infinite digest loop happens.

We need to dig in and understand how to address this.

[cjcenizal]

@alisonelizabeth It looks like the dirty_prompt.js file was removed in the watcher-port branch. Does this mean that the dirty prompt feature was removed in that branch? If so, then does that mean this bug will be fixed once that branch is merged?

[alisonelizabeth]

@cjcenizal it looks like the dirty_prompt functionality had been previously disabled in the existing code as well, see #19595.

You're correct, in the new code, this will not be an issue. That being said, a user is able to cancel with unsaved changes and they will not be prompted to confirm - do you think we need to add support back for this feature?

[cjcenizal]

I think it's a nice-to-have functionality which we should consider more broadly, not just in the context of a specific app. In that light I think we can close this.