Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix yarn-offline-mirror #196224

Merged
merged 4 commits into from
Oct 21, 2024
Merged

[ci] Fix yarn-offline-mirror #196224

merged 4 commits into from
Oct 21, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 14, 2024

Currently CI is configuring a yarn offline mirror outside of the Kibana directory, with the intention of caching assets during image build. This configuration is ignored due to .yarnrc taking precedence, resulting in the offline mirror being setup in the local Kibana installation. On CI start, a fresh checkout of the repository is made and the cache directory is empty.

Instead of setting a user level configuration this modifies .yarnrc with the intended directory.

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 14, 2024
@jbudz
Copy link
Member Author

jbudz commented Oct 14, 2024

buildkite test this

2 similar comments
@jbudz
Copy link
Member Author

jbudz commented Oct 14, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Oct 14, 2024

buildkite test this

Currently CI is configuring a yarn offline mirror outside of the Kibana
directory, with the intention of caching assets during image build.
This configuration is ignored due to .yarnrc taking precedence,
resulting in the offline mirror being setup in the local Kibana
installation. On CI start, a fresh checkout of the repository is
made and the cache directory is empty.

Instead of setting a user level configuration this modifies .yarnrc with
the intended directory.
@jbudz
Copy link
Member Author

jbudz commented Oct 15, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Oct 15, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Oct 15, 2024

buildkite test this

@jbudz jbudz marked this pull request as ready for review October 15, 2024 12:39
@jbudz jbudz requested a review from a team as a code owner October 15, 2024 12:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mistic mistic added backport:all-open Backport to all branches that could still receive a release v9.0.0 and removed backport:skip This commit does not require backporting labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@jbudz jbudz merged commit f793c3b into elastic:main Oct 21, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11444990293

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
Currently CI is configuring a yarn offline mirror outside of the Kibana
directory, with the intention of caching assets during image build. This
configuration is ignored due to .yarnrc taking precedence, resulting in
the offline mirror being setup in the local Kibana installation. On CI
start, a fresh checkout of the repository is made and the cache
directory is empty.

Instead of setting a user level configuration this modifies .yarnrc with
the intended directory.

(cherry picked from commit f793c3b)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
Currently CI is configuring a yarn offline mirror outside of the Kibana
directory, with the intention of caching assets during image build. This
configuration is ignored due to .yarnrc taking precedence, resulting in
the offline mirror being setup in the local Kibana installation. On CI
start, a fresh checkout of the repository is made and the cache
directory is empty.

Instead of setting a user level configuration this modifies .yarnrc with
the intended directory.

(cherry picked from commit f793c3b)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [CI / Build / FIPS] Use xpack.security.experimental.fipsMode.enabled in CI and Docker (#187533)
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196224

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit that referenced this pull request Oct 21, 2024
@jbudz jbudz added the reverted label Oct 21, 2024
jbudz added a commit to jbudz/kibana that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes reverted Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants