[CI / Build / FIPS] Use xpack.security.experimental.fipsMode.enabled in CI and Docker #187533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
added
release_note:skip
|
/ci |
|
/ci |
|
/ci |
|
/ci |
This reverts commit 3e64aa1.
|
/ci |
Ikuni17
commented
Jul 4, 2024
| @@ -156,6 +156,7 @@ RUN /usr/bin/echo -e '\n--enable-fips' >> config/node.options | |||
| RUN /usr/bin/echo '--openssl-config=/usr/share/kibana/config/nodejs.cnf' >> config/node.options | |||
| COPY --chown=1000:0 openssl/nodejs.cnf "/usr/share/kibana/config/nodejs.cnf" | |||
| ENV OPENSSL_MODULES=/usr/share/kibana/openssl/lib/ossl-modules | |||
| ENV XPACK_SECURITY_FIPSMODE_ENABLED=true | |||
There was a problem hiding this comment.
For some reason, this env variable works fine in the Docker image, but isn't picked up in CI, so had to write to to kibana.yml
There was a problem hiding this comment.
@kc13greiner Do you have any idea why this wouldn't work in CI?
There was a problem hiding this comment.
I think it needs EXPERIMENTAL from the xpack.security.experimental.fipsMode.enabled in src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
jbudz
approved these changes
Jul 15, 2024
⏳ Build in-progress
History
cc @Ikuni17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #188272
A check was added to in #181187 which detects if the environment has FIPS enabled NodeJS, but Kibana is not setup properly. This adds the Kibana setting for FIPS in CI and the Docker image. Note there are still license issues on some tests due to #181187 as well, but this will be handled in another PR.