[ML] Transforms: Pagination in the source documents data grid fix #196119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
added
release_note:fix
:ml
Feature:Transforms
|
Pinging @elastic/ml-ui (:ml) |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11330160866 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…astic#196119) ## Summary Fix for: [elastic#195881](elastic#195881) After: It's hardly visible in the recording, but if you look at the `@timestamp` column, you can see that the values are changing correctly while navigating to a previous page, which was not the case before the fix. https://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de (cherry picked from commit 1489396)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…ix (#196119) (#196163) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Transforms: Pagination in the source documents data grid fix (#196119)](#196119) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T15:01:36Z","message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport pending",":ml","Feature:Transforms","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Transforms: Pagination in the source documents data grid fix","number":196119,"url":"https://github.com/elastic/kibana/pull/196119","mergeCommit":{"message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196119","number":196119,"mergeCommit":{"message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
rbrtj
added
v8.15.4
backport:version
|
Starting backport for target branches: 8.15, 8.16 https://github.com/elastic/kibana/actions/runs/11400253996 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…astic#196119) ## Summary Fix for: [elastic#195881](elastic#195881) After: It's hardly visible in the recording, but if you look at the `@timestamp` column, you can see that the values are changing correctly while navigating to a previous page, which was not the case before the fix. https://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de (cherry picked from commit 1489396)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…fix (#196119) (#196814) # Backport This will backport the following commits from `main` to `8.15`: - [[ML] Transforms: Pagination in the source documents data grid fix (#196119)](#196119) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T15:01:36Z","message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Transforms","v9.0.0","Team:ML","v8.16.0","backport:version","v8.15.4"],"title":"[ML] Transforms: Pagination in the source documents data grid fix","number":196119,"url":"https://github.com/elastic/kibana/pull/196119","mergeCommit":{"message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196119","number":196119,"mergeCommit":{"message":"[ML] Transforms: Pagination in the source documents data grid fix (#196119)\n\n## Summary\r\n\r\nFix for: [#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's hardly visible in the recording, but if you look at the\r\n`@timestamp` column, you can see that the values are changing correctly\r\nwhile navigating to a previous page, which was not the case before the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196163","number":196163,"state":"MERGED","mergeCommit":{"sha":"828133d7ed029e82caea98af9c83ed1b4a57f1b9","message":"[8.x] [ML] Transforms: Pagination in the source documents data grid fix (#196119) (#196163)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[ML] Transforms: Pagination in the source documents data grid fix\n(#196119)](https://github.com/elastic/kibana/pull/196119)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Robert\nJaszczurek\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-14T15:01:36Z\",\"message\":\"[ML]\nTransforms: Pagination in the source documents data grid fix\n(#196119)\\n\\n## Summary\\r\\n\\r\\nFix for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly visible in the recording, but if you look at the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing correctly\\r\\nwhile\nnavigating to a previous page, which was not the case before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport\npending\",\":ml\",\"Feature:Transforms\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nTransforms: Pagination in the source documents data grid\nfix\",\"number\":196119,\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Pagination in the source documents data grid fix\n(#196119)\\n\\n## Summary\\r\\n\\r\\nFix for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly visible in the recording, but if you look at the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing correctly\\r\\nwhile\nnavigating to a previous page, which was not the case before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"number\":196119,\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Pagination in the source documents data grid fix\n(#196119)\\n\\n## Summary\\r\\n\\r\\nFix for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly visible in the recording, but if you look at the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing correctly\\r\\nwhile\nnavigating to a previous page, which was not the case before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Robert Jaszczurek <[email protected]>"}},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for: #195881
After:
It's hardly visible in the recording, but if you look at the
@timestampcolumn, you can see that the values are changing correctly while navigating to a previous page, which was not the case before the fix.Screen.Recording.2024-10-14.at.13.21.51.mov