Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Pagination in the source documents data grid is broken when navigating backwards #195881

Closed
rbrtj opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml v8.16.0

Comments

@rbrtj
Copy link
Contributor

rbrtj commented Oct 11, 2024

Kibana version:
9.0
Elasticsearch version:
9.0

Describe the bug:
While navigating backwards in the pagination, the same results are being displayed.

Screen.Recording.2024-10-11.at.12.18.35.mov
@rbrtj rbrtj added :ml bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms labels Oct 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

rbrtj added a commit that referenced this issue Oct 14, 2024
…96119)

## Summary

Fix for: [#195881](#195881)

After:
It's hardly visible in the recording, but if you look at the
`@timestamp` column, you can see that the values are changing correctly
while navigating to a previous page, which was not the case before the
fix.


https://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 14, 2024
…astic#196119)

## Summary

Fix for: [elastic#195881](elastic#195881)

After:
It's hardly visible in the recording, but if you look at the
`@timestamp` column, you can see that the values are changing correctly
while navigating to a previous page, which was not the case before the
fix.

https://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de
(cherry picked from commit 1489396)
kibanamachine added a commit that referenced this issue Oct 14, 2024
…ix (#196119) (#196163)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Transforms: Pagination in the source documents data grid fix
(#196119)](#196119)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T15:01:36Z","message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport
pending",":ml","Feature:Transforms","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML]
Transforms: Pagination in the source documents data grid
fix","number":196119,"url":"https://github.com/elastic/kibana/pull/196119","mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196119","number":196119,"mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
@peteharverson
Copy link
Contributor

Closing, fixed by #196119.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
…astic#196119)

## Summary

Fix for: [elastic#195881](elastic#195881)

After:
It's hardly visible in the recording, but if you look at the
`@timestamp` column, you can see that the values are changing correctly
while navigating to a previous page, which was not the case before the
fix.

https://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de
(cherry picked from commit 1489396)
kibanamachine added a commit that referenced this issue Oct 18, 2024
…fix (#196119) (#196814)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Transforms: Pagination in the source documents data grid fix
(#196119)](#196119)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T15:01:36Z","message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Transforms","v9.0.0","Team:ML","v8.16.0","backport:version","v8.15.4"],"title":"[ML]
Transforms: Pagination in the source documents data grid
fix","number":196119,"url":"https://github.com/elastic/kibana/pull/196119","mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196119","number":196119,"mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196163","number":196163,"state":"MERGED","mergeCommit":{"sha":"828133d7ed029e82caea98af9c83ed1b4a57f1b9","message":"[8.x]
[ML] Transforms: Pagination in the source documents data grid fix
(#196119) (#196163)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.x`:\n- [[ML] Transforms: Pagination in the
source documents data grid
fix\n(#196119)](https://github.com/elastic/kibana/pull/196119)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Robert\nJaszczurek\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-14T15:01:36Z\",\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport\npending\",\":ml\",\"Feature:Transforms\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nTransforms:
Pagination in the source documents data
grid\nfix\",\"number\":196119,\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"number\":196119,\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Robert Jaszczurek
<[email protected]>"}},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml v8.16.0
Projects
None yet
Development

No branches or pull requests

3 participants