Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Presentation Util] Cleanup services (#194201) #195445

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f2208db1a83889c76fd2413a0a133a858f4891e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","technical debt","release_note:skip","impact:high","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Presentation Util] Cleanup services","number":194201,"url":"https://github.com//pull/194201","mergeCommit":{"message":"[Presentation Util] Cleanup services (#194201)\n\nCloses https://github.com//issues/167440\r\n\r\n## Summary\r\n\r\nThis PR refactors the `PresentationUtil` services to no longer use its\r\nown `PluginServiceProvider`. In doing this, it removes the\r\n`PresentationUtil` context provider, since it is no longer necessary.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f2208db1a83889c76fd2413a0a133a858f4891e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/194201","number":194201,"mergeCommit":{"message":"[Presentation Util] Cleanup services (#194201)\n\nCloses https://github.com//issues/167440\r\n\r\n## Summary\r\n\r\nThis PR refactors the `PresentationUtil` services to no longer use its\r\nown `PluginServiceProvider`. In doing this, it removes the\r\n`PresentationUtil` context provider, since it is no longer necessary.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f2208db1a83889c76fd2413a0a133a858f4891e"}}]}] BACKPORT-->

Closes elastic#167440

## Summary

This PR refactors the `PresentationUtil` services to no longer use its
own `PluginServiceProvider`. In doing this, it removes the
`PresentationUtil` context provider, since it is no longer necessary.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

<!--ONMERGE {"backportTargets":["8.x"]} ONMERGE-->

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9f2208d)
@kibanamachine kibanamachine enabled auto-merge (squash) October 8, 2024 15:20
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 9, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationUtil 189 184 -5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
aiops 9 8 -1
presentationUtil 157 148 -9
total -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 554.1KB 554.0KB -133.0B
canvas 1.1MB 1.1MB -61.0B
dashboard 649.9KB 649.9KB -61.0B
lens 1.5MB 1.5MB -63.0B
maps 3.0MB 3.0MB -18.0B
ml 4.6MB 4.6MB -253.0B
observability 467.7KB 467.5KB -137.0B
presentationUtil 86.3KB 87.2KB +993.0B
slo 855.4KB 855.3KB -137.0B
synthetics 1.2MB 1.2MB -162.0B
visualizations 315.6KB 315.5KB -73.0B
total -105.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
eventAnnotationListing 11.0KB 10.9KB -67.0B
lens 51.7KB 51.6KB -163.0B
maps 54.4KB 54.3KB -79.0B
presentationUtil 36.5KB 35.5KB -1.0KB
total -1.3KB
Unknown metric groups

API count

id before after diff
aiops 72 71 -1
presentationUtil 212 201 -11
total -12

References to deprecated APIs

id before after diff
presentationUtil 3 2 -1

History

cc @Heenawter

@kibanamachine kibanamachine merged commit 1aceffc into elastic:8.x Oct 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants