[Presentation Util] Simplify module level services #167440
Assignees
Labels
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
technical debt
Improvement of the software architecture and operational architecture
Comments
ThomThomson
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
added
loe:medium
Heenawter
added
loe:small
This was referenced Sep 26, 2024
Heenawter
added a commit
that referenced
this issue
Oct 8, 2024
Closes #167440 ## Summary This PR refactors the `PresentationUtil` services to no longer use its own `PluginServiceProvider`. In doing this, it removes the `PresentationUtil` context provider, since it is no longer necessary. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) <!--ONMERGE {"backportTargets":["8.x"]} ONMERGE--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 8, 2024
Closes elastic#167440 ## Summary This PR refactors the `PresentationUtil` services to no longer use its own `PluginServiceProvider`. In doing this, it removes the `PresentationUtil` context provider, since it is no longer necessary. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) <!--ONMERGE {"backportTargets":["8.x"]} ONMERGE--> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9f2208d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The Presentation Util plugin currently uses an overcomplicated services layer which requires us to re-state all dependencies, their types and their implementations for stubbed usage, for storybooks (which are mostly unused), and for Kibana. This services layer also causes problems in our adoption of certain Shared UX components, as instead of simply passing in the dependency directly, we need to re-state the dependency fully.
Solution
Instead of the Presentation Util module services, we should standardize on the approach used in the Embeddables plugin. See src/plugins/embeddable/public/kibana_services.ts for more information.
As part of this effort, we should ensure to remove the entire framework from the Presentation Util plugin under
src/plugins/presentation_util/public/servicesso that it cannot be used again.The text was updated successfully, but these errors were encountered: