Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monaco editor functional test service check #195154

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Oct 4, 2024

Summary

This PR fixes a monaco editor functional test service check that was added in #193851. The check validates that the editor updates with the correct text content, but it looks like it may run a bit too quickly sometimes before the DOM has a chance to update.

Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.

Flaky test runs:

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 4, 2024
@davismcphee davismcphee self-assigned this Oct 4, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7099

[✅] test/functional/apps/discover/group4/config.ts: 50/50 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts: 28/50 tests passed.

see run history

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee
Copy link
Contributor Author

On the other hand, the failure in this flaky test run looks to be caused by the issue resolved in #195147, not the one causing these failures. Guess we won't get a clean run until one of them is merged:
image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @davismcphee

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davismcphee davismcphee merged commit 11ff4a9 into elastic:main Oct 8, 2024
23 checks passed
@davismcphee davismcphee deleted the fix-monaco-editor-check branch October 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0
Projects
None yet
5 participants