-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix monaco editor functional test service check #195154
Conversation
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @davismcphee |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7099[✅] test/functional/apps/discover/group4/config.ts: 50/50 tests passed. |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
On the other hand, the failure in this flaky test run looks to be caused by the issue resolved in #195147, not the one causing these failures. Guess we won't get a clean run until one of them is merged: |
💚 Build Succeeded
Metrics [docs]
cc @davismcphee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Summary
This PR fixes a monaco editor functional test service check that was added in #193851. The check validates that the editor updates with the correct text content, but it looks like it may run a bit too quickly sometimes before the DOM has a chance to update.
Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.
Flaky test runs:
Checklist
For maintainers