Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group4/_document_comparison·ts - discover/group4 Discover document comparison ES|QL mode "before all" hook for "should allow comparing documents" #194511

Closed
kibanamachine opened this issue Oct 1, 2024 · 1 comment · Fixed by #195154
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group4/_document_comparison·ts - discover/group4 Discover document comparison ES|QL mode "before all" hook for "should allow comparing documents" #194511

kibanamachine opened this issue Oct 1, 2024 · 1 comment · Fixed by #195154
Assignees
@davismcphee
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: Expected value was: from logstash-* | sort @timestamp desc | limit 10, but got: FROM logstash-* | LIMIT 10
    at Assertion.assert (expect.js:100:11)
    at Assertion.equal (expect.js:227:8)
    at MonacoEditorService.setCodeEditorValue (monaco_editor.ts:67:32)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Context.<anonymous> (_document_comparison.ts:80:9)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 1, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 1, 2024
@kibanamachine kibanamachine added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 1, 2024
@kertal kertal added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 2, 2024
@davismcphee davismcphee self-assigned this Oct 4, 2024
@davismcphee davismcphee mentioned this issue Oct 4, 2024
Merged
10 tasks
davismcphee added a commit that referenced this issue Oct 8, 2024
@davismcphee
Fix monaco editor functional test service check (#195154)
11ff4a9 
## Summary

This PR fixes a monaco editor functional test service check that was
added in #193851. The check validates that the editor updates with the
correct text content, but it looks like it may run a bit too quickly
sometimes before the DOM has a chance to update.

Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.

Flaky test runs:
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7099

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davismcphee davismcphee

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix monaco editor functional test service check davismcphee/kibana
4 participants
@kertal @elasticmachine @davismcphee @kibanamachine