Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] Ensuring definition transforms are managed #193408

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

tiansivive
Copy link
Contributor

@tiansivive tiansivive commented Sep 19, 2024

Summary

This PR adds the managed flag to the entity definitions so that the generated transforms are tagged as such.

How to test

  1. Add EntityStoreEnabled feature flag to your kibana.dev.yml
  2. Call POST kbn:/api/entity_store/engines/<user | host>/init with an empty ({}) body.
  3. Go to Stack Management > Transforms and verify that the 2 new transforms are tagged as managed

Implements https://github.com/elastic/security-team/issues/10608

@tiansivive tiansivive added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team 8.16 candidate labels Sep 19, 2024
@tiansivive tiansivive added this to the 8.16 milestone Sep 19, 2024
@tiansivive tiansivive marked this pull request as ready for review September 19, 2024 11:18
@tiansivive tiansivive requested a review from a team as a code owner September 19, 2024 11:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@tiansivive tiansivive added the release_note:skip Skip the PR/issue when compiling release notes label Sep 19, 2024
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner September 19, 2024 12:00
@tiansivive tiansivive enabled auto-merge (squash) September 23, 2024 10:25
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tiansivive tiansivive merged commit a372162 into elastic:main Sep 23, 2024
40 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
…c#193408)

## Summary

This PR adds the `managed` flag to the entity definitions so that the
generated transforms are tagged as such.

### How to test

1. Add `EntityStoreEnabled` feature flag to your `kibana.dev.yml`
2. Call `POST kbn:/api/entity_store/engines/<user | host>/init` with an
empty (`{}`) body.
3. Go to `Stack Management > Transforms` and verify that the 2 new
transforms are tagged as managed

Implements elastic/security-team#10608

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a372162)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2024
…193408) (#193708)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Entity Analytics] Ensuring definition transforms are managed
(#193408)](#193408)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T11:50:54Z","message":"[Entity
Analytics] Ensuring definition transforms are managed (#193408)\n\n##
Summary\r\n\r\nThis PR adds the `managed` flag to the entity definitions
so that the\r\ngenerated transforms are tagged as such.\r\n\r\n### How
to test\r\n\r\n1. Add `EntityStoreEnabled` feature flag to your
`kibana.dev.yml`\r\n2. Call `POST kbn:/api/entity_store/engines/<user |
host>/init` with an\r\nempty (`{}`) body.\r\n3. Go to `Stack Management
> Transforms` and verify that the 2 new\r\ntransforms are tagged as
managed\r\n\r\nImplements
https://github.com/elastic/security-team/issues/10608\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a372162cf6f7ed88ded984f4501895d4cd88d047","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Theme:
entity_analytics","Feature:Entity Analytics","Team:Entity
Analytics","8.16 candidate"],"title":"[Entity Analytics] Ensuring
definition transforms are
managed","number":193408,"url":"https://github.com/elastic/kibana/pull/193408","mergeCommit":{"message":"[Entity
Analytics] Ensuring definition transforms are managed (#193408)\n\n##
Summary\r\n\r\nThis PR adds the `managed` flag to the entity definitions
so that the\r\ngenerated transforms are tagged as such.\r\n\r\n### How
to test\r\n\r\n1. Add `EntityStoreEnabled` feature flag to your
`kibana.dev.yml`\r\n2. Call `POST kbn:/api/entity_store/engines/<user |
host>/init` with an\r\nempty (`{}`) body.\r\n3. Go to `Stack Management
> Transforms` and verify that the 2 new\r\ntransforms are tagged as
managed\r\n\r\nImplements
https://github.com/elastic/security-team/issues/10608\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a372162cf6f7ed88ded984f4501895d4cd88d047"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193408","number":193408,"mergeCommit":{"message":"[Entity
Analytics] Ensuring definition transforms are managed (#193408)\n\n##
Summary\r\n\r\nThis PR adds the `managed` flag to the entity definitions
so that the\r\ngenerated transforms are tagged as such.\r\n\r\n### How
to test\r\n\r\n1. Add `EntityStoreEnabled` feature flag to your
`kibana.dev.yml`\r\n2. Call `POST kbn:/api/entity_store/engines/<user |
host>/init` with an\r\nempty (`{}`) body.\r\n3. Go to `Stack Management
> Transforms` and verify that the 2 new\r\ntransforms are tagged as
managed\r\n\r\nImplements
https://github.com/elastic/security-team/issues/10608\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a372162cf6f7ed88ded984f4501895d4cd88d047"}}]}]
BACKPORT-->

Co-authored-by: Tiago Vila Verde <[email protected]>
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Theme: entity_analytics v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants