[ML] AIOps: Move Log Rate Analysis results callout to help popover. #192243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-aiops-log-rate-analysis-help-popover
branch
2 times, most recently
from
d712ff1 to
8f278bf
Compare
walterra
force-pushed
the
ml-aiops-log-rate-analysis-help-popover
branch
from
8f278bf to
f4b29bf
Compare
walterra
added
v9.0.0
v8.16.0
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
walterra
commented
Sep 13, 2024
| </EuiPopoverTitle> | ||
| )} | ||
|
|
||
| <EuiText size="s" css={{ maxWidth: `calc(${euiTheme.euiSizeXL} * 15);` }}> |
There was a problem hiding this comment.
This is a bit weird but it's a mix of what the EUI docs say to do with their sizes and what I copied over from the ml help popover while getting rid of the SCSS there.
x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_info_popover.tsx
Show resolved
Hide resolved
rbrtj
reviewed
Sep 16, 2024
x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_info_popover.tsx
Show resolved
Hide resolved
walterra
added
the
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
…lastic#192243) ## Summary Moves the callout that describes some analysis details to a help popover. Before: <img width="1064" alt="image" src="https://github.com/user-attachments/assets/cb2820f9-8cdc-4d31-98ac-df199509767a"> After: <img width="1174" alt="image" src="https://github.com/user-attachments/assets/dc795816-6da6-4e58-bc86-d490034140ce"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit dc9fb65)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
…ver. (#192243) (#193675) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Move Log Rate Analysis results callout to help popover. (#192243)](#192243) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T08:10:48Z","message":"[ML] AIOps: Move Log Rate Analysis results callout to help popover. (#192243)\n\n## Summary\r\n\r\nMoves the callout that describes some analysis details to a help\r\npopover.\r\n\r\nBefore:\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cb2820f9-8cdc-4d31-98ac-df199509767a\">\r\n\r\nAfter:\r\n\r\n<img width=\"1174\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dc795816-6da6-4e58-bc86-d490034140ce\">\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"dc9fb650412bd678b80dad52f66a413feff6035a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","backport:prev-minor","Feature:ML/AIOps","v8.16.0"],"title":"[ML] AIOps: Move Log Rate Analysis results callout to help popover.","number":192243,"url":"https://github.com/elastic/kibana/pull/192243","mergeCommit":{"message":"[ML] AIOps: Move Log Rate Analysis results callout to help popover. (#192243)\n\n## Summary\r\n\r\nMoves the callout that describes some analysis details to a help\r\npopover.\r\n\r\nBefore:\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cb2820f9-8cdc-4d31-98ac-df199509767a\">\r\n\r\nAfter:\r\n\r\n<img width=\"1174\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dc795816-6da6-4e58-bc86-d490034140ce\">\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"dc9fb650412bd678b80dad52f66a413feff6035a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192243","number":192243,"mergeCommit":{"message":"[ML] AIOps: Move Log Rate Analysis results callout to help popover. (#192243)\n\n## Summary\r\n\r\nMoves the callout that describes some analysis details to a help\r\npopover.\r\n\r\nBefore:\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cb2820f9-8cdc-4d31-98ac-df199509767a\">\r\n\r\nAfter:\r\n\r\n<img width=\"1174\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dc795816-6da6-4e58-bc86-d490034140ce\">\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"dc9fb650412bd678b80dad52f66a413feff6035a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
weizijun
added a commit
to weizijun/kibana
that referenced
this pull request
Sep 23, 2024
* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the callout that describes some analysis details to a help popover.
Before:
After:
Checklist