[ML] AIOps: Log Rate Analysis embeddable #192167
Closed
+166,407
−242,236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-aiops-log-rate-analysis-embeddable
branch
from
f036bf6 to
e8ff186
Compare
walterra
force-pushed
the
ml-aiops-log-rate-analysis-embeddable
branch
5 times, most recently
from
bed0540 to
07fdd72
Compare
walterra
force-pushed
the
ml-aiops-log-rate-analysis-embeddable
branch
from
c2c775a to
93055db
Compare
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
force-pushed
the
ml-aiops-log-rate-analysis-embeddable
branch
2 times, most recently
from
d99a585 to
18a1cda
Compare
23 tasks
x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx
Outdated
Show resolved
Hide resolved
walterra
added
:ml
v9.0.0
v8.16.0
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
|
As discussed offline, I'm seeing some odd effects when I try to add more than 1 log rate analysis embeddable panel to the same dashboard. Brush selection doesn't seem to work on the second panel. |
|
I'm seeing an issue where changing the data view doesn't appear to be affecting the visualization. The chart doesn't change. 2024-10-10.10-18-09.2024-10-10.10_19_24.mp4 |
...gins/aiops/public/components/log_rate_analysis_results_table/use_view_in_discover_action.tsx
Show resolved
Hide resolved
|
I'm finding that the labels for the brushes are moving as the panel contents is scrolled: 
|
|
As discussed offline, I saw a regression regarding time range changes, where I started getting no results after moving the deviation to a different range and then back again. See if you can reproduce. Doesn't seem to happen on Screen.Recording.2024-10-10.at.10.44.39.mov |
|
Fixes done:
|
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
sorry for the noise, pushed a wrong update. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
cc @walterra |
12 tasks
walterra
added a commit
that referenced
this pull request
Nov 5, 2024
## Summary Follow up to #192167 (rebase/push gone wrong) <img width="1920" alt="image" src="https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a"> - [x] Let's users create a Log Rate Analysis panel using the "Add Panel" button when editing dashboards. - [x] Retains functionality of links in results table to Discover and Pattern Analysis. [41b4337](41b4337) - [x] Create `Logs AIOps` section in Add Panel menu. - [x] Brushes not working with multiple panels fixed in [75ca4ca](75ca4ca). The reason was the `DualBrush` component used hard coded html ids. - [x] Panel now updates when data view is changed in options flyout, fixed in [2b58567](2b58567). - [x] When the user selects a data view without time field, we now show the same warning as used for pattern analysis and the apply button gets disabled, fixed in [a01975d](a01975d). - [x] Pass on and use global search/filters to embeddable. [2c24dbd](2c24dbd) - [x] Moving labels [26cd1a5](26cd1a5) - [x] No results after time range update [632b711](632b711) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
## Summary Follow up to elastic#192167 (rebase/push gone wrong) <img width="1920" alt="image" src="https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a"> - [x] Let's users create a Log Rate Analysis panel using the "Add Panel" button when editing dashboards. - [x] Retains functionality of links in results table to Discover and Pattern Analysis. [41b4337](elastic@41b4337) - [x] Create `Logs AIOps` section in Add Panel menu. - [x] Brushes not working with multiple panels fixed in [75ca4ca](elastic@75ca4ca). The reason was the `DualBrush` component used hard coded html ids. - [x] Panel now updates when data view is changed in options flyout, fixed in [2b58567](elastic@2b58567). - [x] When the user selects a data view without time field, we now show the same warning as used for pattern analysis and the apply button gets disabled, fixed in [a01975d](elastic@a01975d). - [x] Pass on and use global search/filters to embeddable. [2c24dbd](elastic@2c24dbd) - [x] Moving labels [26cd1a5](elastic@26cd1a5) - [x] No results after time range update [632b711](elastic@632b711) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6b77e05)
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Log Rate Analysis embeddable (#197943)](#197943) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T14:48:45Z","message":"[ML] AIOps: Log Rate Analysis embeddable (#197943)\n\n## Summary\r\n\r\nFollow up to #192167 (rebase/push gone wrong)\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a\">\r\n\r\n- [x] Let's users create a Log Rate Analysis panel using the \"Add Panel\"\r\nbutton when editing dashboards.\r\n- [x] Retains functionality of links in results table to Discover and\r\nPattern Analysis.\r\n[41b4337](https://github.com/elastic/kibana/pull/192167/commits/41b4337f9ac15103c6b151c94cfb6b7f944aeb89)\r\n- [x] Create `Logs AIOps` section in Add Panel menu.\r\n- [x] Brushes not working with multiple panels fixed in\r\n[75ca4ca](https://github.com/elastic/kibana/pull/192167/commits/75ca4cac37abda94ae7fb9d5132283e1def0b85e).\r\nThe reason was the `DualBrush` component used hard coded html ids.\r\n- [x] Panel now updates when data view is changed in options flyout,\r\nfixed in\r\n[2b58567](https://github.com/elastic/kibana/pull/192167/commits/2b5856777151d3ccc5e882c895704008e575aaff).\r\n- [x] When the user selects a data view without time field, we now show\r\nthe same warning as used for pattern analysis and the apply button gets\r\ndisabled, fixed in\r\n[a01975d](https://github.com/elastic/kibana/pull/192167/commits/a01975dba7b5218ea0f094ebc5cb74cd8670131a).\r\n- [x] Pass on and use global search/filters to embeddable.\r\n[2c24dbd](https://github.com/elastic/kibana/pull/192167/commits/2c24dbd116ef4ae19ff58796b2c5fc4f61a86234)\r\n- [x] Moving labels\r\n[26cd1a5](https://github.com/elastic/kibana/pull/192167/commits/26cd1a53dfbbea34094cd840eb885a78f29d8de6)\r\n- [x] No results after time range update\r\n[632b711](https://github.com/elastic/kibana/pull/192167/commits/632b711ca1de77d113192649f56c5b18ae453f86)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6b77e05586524892dc42c34d0b5b2a561cebc0ae","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","v9.0.0","release_note:feature","Feature:ML/AIOps","backport:version","v8.17.0"],"title":"[ML] AIOps: Log Rate Analysis embeddable","number":197943,"url":"https://github.com/elastic/kibana/pull/197943","mergeCommit":{"message":"[ML] AIOps: Log Rate Analysis embeddable (#197943)\n\n## Summary\r\n\r\nFollow up to #192167 (rebase/push gone wrong)\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a\">\r\n\r\n- [x] Let's users create a Log Rate Analysis panel using the \"Add Panel\"\r\nbutton when editing dashboards.\r\n- [x] Retains functionality of links in results table to Discover and\r\nPattern Analysis.\r\n[41b4337](https://github.com/elastic/kibana/pull/192167/commits/41b4337f9ac15103c6b151c94cfb6b7f944aeb89)\r\n- [x] Create `Logs AIOps` section in Add Panel menu.\r\n- [x] Brushes not working with multiple panels fixed in\r\n[75ca4ca](https://github.com/elastic/kibana/pull/192167/commits/75ca4cac37abda94ae7fb9d5132283e1def0b85e).\r\nThe reason was the `DualBrush` component used hard coded html ids.\r\n- [x] Panel now updates when data view is changed in options flyout,\r\nfixed in\r\n[2b58567](https://github.com/elastic/kibana/pull/192167/commits/2b5856777151d3ccc5e882c895704008e575aaff).\r\n- [x] When the user selects a data view without time field, we now show\r\nthe same warning as used for pattern analysis and the apply button gets\r\ndisabled, fixed in\r\n[a01975d](https://github.com/elastic/kibana/pull/192167/commits/a01975dba7b5218ea0f094ebc5cb74cd8670131a).\r\n- [x] Pass on and use global search/filters to embeddable.\r\n[2c24dbd](https://github.com/elastic/kibana/pull/192167/commits/2c24dbd116ef4ae19ff58796b2c5fc4f61a86234)\r\n- [x] Moving labels\r\n[26cd1a5](https://github.com/elastic/kibana/pull/192167/commits/26cd1a53dfbbea34094cd840eb885a78f29d8de6)\r\n- [x] No results after time range update\r\n[632b711](https://github.com/elastic/kibana/pull/192167/commits/632b711ca1de77d113192649f56c5b18ae453f86)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6b77e05586524892dc42c34d0b5b2a561cebc0ae"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197943","number":197943,"mergeCommit":{"message":"[ML] AIOps: Log Rate Analysis embeddable (#197943)\n\n## Summary\r\n\r\nFollow up to #192167 (rebase/push gone wrong)\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a\">\r\n\r\n- [x] Let's users create a Log Rate Analysis panel using the \"Add Panel\"\r\nbutton when editing dashboards.\r\n- [x] Retains functionality of links in results table to Discover and\r\nPattern Analysis.\r\n[41b4337](https://github.com/elastic/kibana/pull/192167/commits/41b4337f9ac15103c6b151c94cfb6b7f944aeb89)\r\n- [x] Create `Logs AIOps` section in Add Panel menu.\r\n- [x] Brushes not working with multiple panels fixed in\r\n[75ca4ca](https://github.com/elastic/kibana/pull/192167/commits/75ca4cac37abda94ae7fb9d5132283e1def0b85e).\r\nThe reason was the `DualBrush` component used hard coded html ids.\r\n- [x] Panel now updates when data view is changed in options flyout,\r\nfixed in\r\n[2b58567](https://github.com/elastic/kibana/pull/192167/commits/2b5856777151d3ccc5e882c895704008e575aaff).\r\n- [x] When the user selects a data view without time field, we now show\r\nthe same warning as used for pattern analysis and the apply button gets\r\ndisabled, fixed in\r\n[a01975d](https://github.com/elastic/kibana/pull/192167/commits/a01975dba7b5218ea0f094ebc5cb74cd8670131a).\r\n- [x] Pass on and use global search/filters to embeddable.\r\n[2c24dbd](https://github.com/elastic/kibana/pull/192167/commits/2c24dbd116ef4ae19ff58796b2c5fc4f61a86234)\r\n- [x] Moving labels\r\n[26cd1a5](https://github.com/elastic/kibana/pull/192167/commits/26cd1a53dfbbea34094cd840eb885a78f29d8de6)\r\n- [x] No results after time range update\r\n[632b711](https://github.com/elastic/kibana/pull/192167/commits/632b711ca1de77d113192649f56c5b18ae453f86)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6b77e05586524892dc42c34d0b5b2a561cebc0ae"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
## Summary Follow up to elastic#192167 (rebase/push gone wrong) <img width="1920" alt="image" src="https://github.com/user-attachments/assets/0ee12b65-0bff-4a02-805d-adab1be2a52a"> - [x] Let's users create a Log Rate Analysis panel using the "Add Panel" button when editing dashboards. - [x] Retains functionality of links in results table to Discover and Pattern Analysis. [41b4337](elastic@41b4337) - [x] Create `Logs AIOps` section in Add Panel menu. - [x] Brushes not working with multiple panels fixed in [75ca4ca](elastic@75ca4ca). The reason was the `DualBrush` component used hard coded html ids. - [x] Panel now updates when data view is changed in options flyout, fixed in [2b58567](elastic@2b58567). - [x] When the user selects a data view without time field, we now show the same warning as used for pattern analysis and the apply button gets disabled, fixed in [a01975d](elastic@a01975d). - [x] Pass on and use global search/filters to embeddable. [2c24dbd](elastic@2c24dbd) - [x] Moving labels [26cd1a5](elastic@26cd1a5) - [x] No results after time range update [632b711](elastic@632b711) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logs AIOpssection in Add Panel menu.DualBrushcomponent used hard coded html ids.Checklist
Delete any items that are not applicable to this PR.