fix url locator

elastic · Oct 10, 2024 · 41b4337 · 41b4337
1 parent a01975d
commit 41b4337
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 48 deletions.
diff --git a/...ins/aiops/public/embeddables/change_point_chart/embeddable_change_point_chart_factory.tsx b/...ins/aiops/public/embeddables/change_point_chart/embeddable_change_point_chart_factory.tsx
@@ -63,20 +63,6 @@ export const getChangePointChartEmbeddableFactory = (
     buildEmbeddable: async (state, buildApi, uuid, parentApi) => {
       const [coreStart, pluginStart] = await getStartServices();
 
-      const { http, uiSettings, notifications, ...startServices } = coreStart;
-      const { lens, data, usageCollection, fieldFormats } = pluginStart;
-
-      const deps = {
-        http,
-        uiSettings,
-        data,
-        notifications,
-        lens,
-        usageCollection,
-        fieldFormats,
-        ...startServices,
-      };
-
       const {
         api: timeRangeApi,
         comparators: timeRangeComparators,
@@ -95,7 +81,7 @@ export const getChangePointChartEmbeddableFactory = (
       const blockingError = new BehaviorSubject<Error | undefined>(undefined);
 
       const dataViews$ = new BehaviorSubject<DataView[] | undefined>([
-        await deps.data.dataViews.get(state.dataViewId),
+        await pluginStart.data.dataViews.get(state.dataViewId),
       ]);
 
       const api = buildApi(

diff --git a/...ugins/aiops/public/embeddables/log_rate_analysis/embeddable_log_rate_analysis_factory.tsx b/...ugins/aiops/public/embeddables/log_rate_analysis/embeddable_log_rate_analysis_factory.tsx
@@ -61,20 +61,6 @@ export const getLogRateAnalysisEmbeddableFactory = (
     buildEmbeddable: async (state, buildApi, uuid, parentApi) => {
       const [coreStart, pluginStart] = await getStartServices();
 
-      const { http, uiSettings, notifications, ...startServices } = coreStart;
-      const { lens, data, usageCollection, fieldFormats } = pluginStart;
-
-      const deps = {
-        http,
-        uiSettings,
-        data,
-        notifications,
-        lens,
-        usageCollection,
-        fieldFormats,
-        ...startServices,
-      };
-
       const {
         api: timeRangeApi,
         comparators: timeRangeComparators,
@@ -93,8 +79,8 @@ export const getLogRateAnalysisEmbeddableFactory = (
       const blockingError = new BehaviorSubject<Error | undefined>(undefined);
 
       const dataViews$ = new BehaviorSubject<DataView[] | undefined>([
-        await deps.data.dataViews.get(
-          state.dataViewId ?? (await deps.data.dataViews.getDefaultId())
+        await pluginStart.data.dataViews.get(
+          state.dataViewId ?? (await pluginStart.data.dataViews.getDefaultId())
         ),
       ]);
 

diff --git a/...plugins/aiops/public/embeddables/pattern_analysis/embeddable_pattern_analysis_factory.tsx b/...plugins/aiops/public/embeddables/pattern_analysis/embeddable_pattern_analysis_factory.tsx
@@ -60,20 +60,6 @@ export const getPatternAnalysisEmbeddableFactory = (
     buildEmbeddable: async (state, buildApi, uuid, parentApi) => {
       const [coreStart, pluginStart] = await getStartServices();
 
-      const { http, uiSettings, notifications, ...startServices } = coreStart;
-      const { lens, data, usageCollection, fieldFormats } = pluginStart;
-
-      const deps = {
-        http,
-        uiSettings,
-        data,
-        notifications,
-        lens,
-        usageCollection,
-        fieldFormats,
-        ...startServices,
-      };
-
       const {
         api: timeRangeApi,
         comparators: timeRangeComparators,
@@ -92,8 +78,8 @@ export const getPatternAnalysisEmbeddableFactory = (
       const blockingError = new BehaviorSubject<Error | undefined>(undefined);
 
       const dataViews$ = new BehaviorSubject<DataView[] | undefined>([
-        await deps.data.dataViews.get(
-          state.dataViewId ?? (await deps.data.dataViews.getDefaultId())
+        await pluginStart.data.dataViews.get(
+          state.dataViewId ?? (await pluginStart.data.dataViews.getDefaultId())
         ),
       ]);
 

diff --git a/x-pack/plugins/aiops/public/shared_components/log_rate_analysis_embeddable_wrapper.tsx b/x-pack/plugins/aiops/public/shared_components/log_rate_analysis_embeddable_wrapper.tsx
@@ -75,7 +75,7 @@ const LogRateAnalysisEmbeddableWrapperWithDeps: FC<LogRateAnalysisPropsWithDeps>
   lastReloadRequestTime,
 }) => {
   const deps = useMemo(() => {
-    const { lens, data, usageCollection, fieldFormats, charts, storage, unifiedSearch } =
+    const { lens, data, usageCollection, fieldFormats, charts, share, storage, unifiedSearch } =
       pluginStart;
 
     return {
@@ -84,6 +84,7 @@ const LogRateAnalysisEmbeddableWrapperWithDeps: FC<LogRateAnalysisPropsWithDeps>
       usageCollection,
       fieldFormats,
       charts,
+      share,
       storage,
       unifiedSearch,
       ...coreStart,