[ResponseOps][TaskManager] followups from resource based scheduling PR #192124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
doakalexi
changed the title
doakalexi
added
Team:ResponseOps
|
/ci |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jbudz
approved these changes
Sep 5, 2024
ymao1
reviewed
Sep 5, 2024
src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
Outdated
Show resolved
Hide resolved
ymao1
reviewed
Sep 9, 2024
| @@ -48,6 +49,9 @@ Enables event loop delay monitoring, which will log a warning when a task causes | |||
| `xpack.task_manager.event_loop_delay.warn_threshold`:: | |||
| Sets the amount of event loop delay during a task execution which will cause a warning to be logged. Defaults to 5000 milliseconds (5 seconds). | |||
|
|
|||
| `xpack.task_manager.capacity`:: | |||
| Sets the number of normal cost tasks that can be run at one time. Can be minimum 5 and maximum 50. Defaults to 10. | |||
There was a problem hiding this comment.
What about something like controls the number of tasks that can be run at one time? cc @lcawl
Wording can be confusing because the capacity means something different depending on what the claim strategy is. It is either the number of tasks that can be run at one time or the total cost of tasks that can be run at one time.
There was a problem hiding this comment.
Yeah that makes sense to me! Thanks
There was a problem hiding this comment.
I update the text in this commit baf8040
…exi/kibana into resource-based-schedule-followups
lcawl
reviewed
Sep 10, 2024
docs/user/production-considerations/task-manager-production-considerations.asciidoc
Outdated
Show resolved
Hide resolved
docs/user/production-considerations/task-manager-troubleshooting.asciidoc
Outdated
Show resolved
Hide resolved
…ng.asciidoc Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
…nsiderations.asciidoc Co-authored-by: Lisa Cawley <[email protected]>
lcawl
approved these changes
Sep 12, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #190095, #192183, #192185
Summary
This PR updates the following:
maxAllowedCostto be the default capacity of 10xpack.alerting.maxScheduledPerMinute,xpack.discovery.active_nodes_lookback,xpack.discovery.intervalconfigs to dockerxpack.task_manager.capacity