Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][TaskManager] followups from resource based scheduling PR #190095

Closed
pmuellr opened this issue Aug 7, 2024 · 1 comment
Closed

[ResponseOps][TaskManager] followups from resource based scheduling PR #190095

pmuellr opened this issue Aug 7, 2024 · 1 comment
Assignees
@doakalexi
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Aug 7, 2024

While reviewing #189626 , I noted a few potential issues, collected here to follow up on:

  • need to add new config to our docker and cloud allow lists: comment
  • change heap-to-capacity converter to take into account larger amounts of RAM comment
  • maxAllowedCost seems lazily initialized, so wondering if anything is sensitive to the initial value of 0 - comment
@pmuellr pmuellr added Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@pmuellr pmuellr mentioned this issue Aug 7, 2024
Merged
@doakalexi doakalexi self-assigned this Aug 28, 2024
@doakalexi doakalexi mentioned this issue Sep 4, 2024
Merged
doakalexi added a commit that referenced this issue Sep 12, 2024
@doakalexi @lcawl
[ResponseOps][TaskManager] followups from resource based scheduling PR (
850cdf0 
#192124)

Towards #190095,
#192183,
#192185

## Summary

This PR updates the following:

- heap-to-capacity converter to take into account larger amounts of RAM,
updated this to be 16GB
- initial`maxAllowedCost` to be the default capacity of 10
- adds `xpack.alerting.maxScheduledPerMinute`,
`xpack.discovery.active_nodes_lookback`, `xpack.discovery.interval`
configs to docker
- updates the TM docs for `xpack.task_manager.capacity`

---------

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doakalexi doakalexi

Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmuellr @elasticmachine @doakalexi