Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs] Provide help for migrating Logs UI settings #189646

Merged
merged 13 commits into from
Aug 14, 2024
Merged

[Logs] Provide help for migrating Logs UI settings #189646

merged 13 commits into from
Aug 14, 2024

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Jul 31, 2024 •
edited
Loading

Summary

This implements #186824.

A new API has been added so that automated corrective actions can be applied.

UI / UX

migration

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@Kerry350 Kerry350 self-assigned this Jul 31, 2024
@Kerry350 Kerry350 added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team labels Jul 31, 2024
@Kerry350 Kerry350 force-pushed the 186824-logs-ui-settings-migration-help branch from 0d6c498 to 564309f Compare August 7, 2024 09:50
@Kerry350 Kerry350 force-pushed the 186824-logs-ui-settings-migration-help branch from 564309f to b1adcd2 Compare August 7, 2024 12:35
@Kerry350
Copy link
Contributor Author

Kerry350 commented Aug 7, 2024

/ci

@Kerry350 Kerry350 marked this pull request as ready for review August 7, 2024 15:03
@Kerry350 Kerry350 requested review from a team as code owners August 7, 2024 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 7, 2024
@Kerry350 Kerry350 removed the request for review from a team August 7, 2024 15:08
@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@weltenwort weltenwort self-requested a review August 12, 2024 11:32
weltenwort
weltenwort reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well 👍

Do you know what the expectations around spaces and the upgrade assistant are? Should it enumerate the deprecations for all spaces? Or is the user expected to visit it once in every space?

...s/observability_solution/logs_shared/server/routes/deprecations/migrate_log_view_settings.ts Show resolved Hide resolved
x-pack/plugins/observability_solution/logs_shared/server/deprecations/log_sources_setting.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/logs_shared/server/deprecations/log_sources_setting.ts Outdated Show resolved Hide resolved
@Kerry350
Copy link
Contributor Author

Kerry350 commented Aug 13, 2024 •
edited
Loading

@weltenwort Thanks for the review.

Do you know what the expectations around spaces and the upgrade assistant are? Should it enumerate the deprecations for all spaces? Or is the user expected to visit it once in every space?

I couldn't find any explicit documentation over spaces and migrations. However, when I looked at other migrations that interacted with Saved Objects they seemed to also be done in this manner (once per space). My assumption was also that we probably don't want to land one big migration across spaces given how users use it for segmentation and configuration, it could be surprising. Potentially one space is ready for migration, one isn't yet etc.

@weltenwort
Copy link
Member

My assumption was also that we probably don't want to land one big migration across spaces

Good point. Ideally the upgrade assistant would list a separate problem for each space. I just wondered if that needs to be included in the deprecation factory or outside of it by the assistant itself.

@Kerry350
Copy link
Contributor Author

Summary after speaking to some core folks / investigating:

It doesn't look like a "migrate all spaces" approach will be possible with the functionality we have available at the moment.

  • We can gather all spaces via the spaces plugin (or even via saved objects).
  • We can then update all log view saved objects using those space names via the namespace property.
  • We can't update the advanced setting for all the spaces. The UI Settings client doesn't provide an equivalent namespace option. We could potentially manually update the saved objects that back the settings, but it seems very risky looking at the protections in the write method of the UI Settings client.

We'll keep the "once per space" approach for now, and we can amend things if platform guidance changes.

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the thoroughness

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 14, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: ad6fbb7
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-189646-ad6fbb770712

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

@Kerry350 Kerry350 merged commit fc12e58 into elastic:main Aug 14, 2024
23 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 14, 2024
wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 18, 2024
@wayneseymour
[FTR][Ownership] Assign logstash, metrics ui, etc
267c8ed 
Assigned lists due to the api called is defined here: https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/exceptions.ts#L54
\cc @elastic/security-detection-engine

Assigned  Logs Shared due to elastic#189646
\cc @elastic/obs-ux-logs-team

Assigned logstash due to https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/plugins/logstash/kibana.jsonc#L4
\cc @elastic/logstash

Assigned metris ui due to https://github.com/elastic/kibana/blob/4f85a9989373fae228ab7969b671b6817d5ecf79/x-pack/plugins/observability_solution/infra/kibana.jsonc#L4
\cc @elastic/obs-ux-logs-team & @elastic/obs-ux-infra_services-team

Contributes to: elastic#194817
@wayneseymour wayneseymour mentioned this pull request Oct 18, 2024
Merged
wayneseymour added a commit that referenced this pull request Oct 23, 2024
@wayneseymour @kibanamachine @elasticmachine
[FTR][Ownership] Assign logstash, metrics ui, etc (#196919)
0409f98 
## Summary

Hopefully assigning to not too large of a reviewers list.

### Reasons for Assignments

Assigned lists due to the api called is defined here:
https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/exceptions.ts#L54
\cc @elastic/security-detection-engine

Assigned Logs Shared due to
#189646 \cc
@elastic/obs-ux-logs-team

Assigned logstash due to
https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/plugins/logstash/kibana.jsonc#L4
\cc @elastic/logstash

Assigned metris ui due to
https://github.com/elastic/kibana/blob/4f85a9989373fae228ab7969b671b6817d5ecf79/x-pack/plugins/observability_solution/infra/kibana.jsonc#L4
\cc @elastic/obs-ux-logs-team & @elastic/obs-ux-infra_services-team

Contributes to: #194817

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@rudolf rudolf mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@weltenwort weltenwort weltenwort approved these changes

Assignees

@Kerry350 Kerry350

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kerry350 @obltmachine @elasticmachine @weltenwort @kibana-ci @Ikuni17 @kibanamachine