Use constant

elastic · Aug 7, 2024 · 6530c50 · 6530c50
1 parent b1adcd2
commit 6530c50
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/x-pack/plugins/observability_solution/logs_shared/server/deprecations/log_sources_setting.ts b/x-pack/plugins/observability_solution/logs_shared/server/deprecations/log_sources_setting.ts
@@ -7,6 +7,7 @@
 import { DeprecationsDetails } from '@kbn/core-deprecations-common';
 import { GetDeprecationsContext } from '@kbn/core-deprecations-server';
 import { i18n } from '@kbn/i18n';
+import { defaultLogViewId } from '../../common/log_views';
 import { MIGRATE_LOG_VIEW_SETTINGS_URL } from '../../common/http_api/deprecations';
 import { logSourcesKibanaAdvancedSettingRT } from '../../common';
 import { LogsSharedPluginStartServicesAccessor } from '../types';
@@ -29,7 +30,7 @@ export const getLogSourcesSettingDeprecationInfo = async ({
     logSourcesService
   );
 
-  const logView = await logViewsClient.getLogView('default');
+  const logView = await logViewsClient.getLogView(defaultLogViewId);
 
   if (logView && !logSourcesKibanaAdvancedSettingRT.is(logView.attributes.logIndices)) {
     return [

diff --git a/x-pack/plugins/observability_solution/logs_shared/server/plugin.ts b/x-pack/plugins/observability_solution/logs_shared/server/plugin.ts
@@ -25,6 +25,7 @@ import { LogsSharedKibanaLogEntriesAdapter } from './lib/adapters/log_entries/ki
 import { LogEntriesService } from './services/log_entries';
 import { LogsSharedConfig } from '../common/plugin_config';
 import { registerDeprecations } from './deprecations';
+import { defaultLogViewId } from '../common/log_views';
 
 export class LogsSharedPlugin
   implements
@@ -59,7 +60,7 @@ export class LogsSharedPlugin
       core.savedObjects.registerType(logViewSavedObjectType);
     } else {
       // Register a static internal view to use as a fallback when the log view SO is not registered
-      logViews.defineInternalLogView('default', {});
+      logViews.defineInternalLogView(defaultLogViewId, {});
     }
 
     const domainLibs: LogsSharedDomainLibs = {

diff --git a/...bservability_solution/logs_shared/server/routes/deprecations/migrate_log_view_settings.ts b/...bservability_solution/logs_shared/server/routes/deprecations/migrate_log_view_settings.ts
@@ -31,7 +31,7 @@ export const initMigrateLogViewSettingsRoute = ({
           );
         const logViewsClient = pluginStart.logViews.getScopedClient(request);
 
-        const logView = await logViewsClient.getLogView('default');
+        const logView = await logViewsClient.getLogView(defaultLogViewId);
 
         if (!logView || logSourcesKibanaAdvancedSettingRT.is(logView.attributes.logIndices)) {
           return response.customError({