Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search] Display dataviews in the EuiCombobox as a text and not pills #189474

Merged
merged 6 commits into from
Jul 31, 2024
Merged

[Unified Search] Display dataviews in the EuiCombobox as a text and not pills #189474

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a59160b
[Unified Search] Display dataviews in the EuiCombobox as a text and n…
mbondyra Jul 30, 2024
a912371
Merge branch 'main' into unified_search/render_dataviews_as_text
mbondyra Jul 30, 2024
56db231
Merge branch 'main' into unified_search/render_dataviews_as_text
mbondyra Jul 30, 2024
e826a1e
Merge branch 'main' into unified_search/render_dataviews_as_text
mbondyra Jul 30, 2024
0e9e391
Refactor index pattern select component to improve performance and re…
mbondyra Jul 30, 2024
a5625ed
Merge branch 'main' into unified_search/render_dataviews_as_text
mbondyra Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/plugins/unified_search/public/index_pattern_select/index_pattern_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ import { Required } from '@kbn/utility-types';
import { EuiComboBox, EuiComboBoxProps } from '@elastic/eui';
import { calculateWidthFromEntries } from '@kbn/calculate-width-from-char-count';
import type { DataViewsContract } from '@kbn/data-views-plugin/public';
import { MIDDLE_TRUNCATION_PROPS } from '../filter_bar/filter_editor/lib/helpers';
import {
MIDDLE_TRUNCATION_PROPS,
SINGLE_SELECTION_AS_TEXT_PROPS,
} from '../filter_bar/filter_editor/lib/helpers';

export type IndexPatternSelectProps = Required<
Omit<EuiComboBoxProps<any>, 'onSearchChange' | 'options' | 'selectedOptions' | 'onChange'>,
Expand Down Expand Up @@ -117,7 +120,7 @@ export default class IndexPatternSelect extends Component<IndexPatternSelectInte

this.setState({
isLoading: false,
options,
options: options.sort((a, b) => a.label.localeCompare(b.label)),
});

if (this.props.onNoIndexPatterns && searchValue === '' && options.length === 0) {
Expand Down Expand Up @@ -155,7 +158,7 @@ export default class IndexPatternSelect extends Component<IndexPatternSelectInte
<EuiComboBox
{...rest}
placeholder={placeholder}
singleSelection={true}
singleSelection={SINGLE_SELECTION_AS_TEXT_PROPS}
isLoading={this.state.isLoading || this.props.isLoading}
onSearchChange={this.fetchOptions}
options={this.state.options}
Expand Down