Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Search] Display dataviews in the EuiCombobox as a text and not pills #189474

Merged
merged 6 commits into from
Jul 31, 2024
Merged

[Unified Search] Display dataviews in the EuiCombobox as a text and not pills #189474

merged 6 commits into from
Jul 31, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 30, 2024 •
edited
Loading

Doesn't display dataviews as pills but as a plain text. Adds sorting too. Before:

Screenshot 2024-07-30 at 10 47 25

After:
Screenshot 2024-07-30 at 10 46 52

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Feature:Unified search Unified search related tasks v8.16.0 labels Jul 30, 2024
@mbondyra mbondyra requested a review from a team as a code owner July 30, 2024 08:41
@mbondyra mbondyra mentioned this pull request Jul 30, 2024
Merged
@mbondyra mbondyra force-pushed the unified_search/render_dataviews_as_text branch from b26192b to 0e9e391 Compare July 30, 2024 14:39
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 222.0KB 222.1KB +47.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 06c18d9 into elastic:main Jul 31, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbondyra @kibana-ci @nickofthyme @kibanamachine