Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] removes feature flag for AI assistant on rule create form #189040

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[Security Solution][Detection Engine] removes feature flag for AI assistant on rule create form #189040

merged 2 commits into from
Jul 25, 2024

Conversation

vitaliidm
Copy link
Contributor

Summary

  • removes feature flag AIAssistantOnRuleCreationFormEnabled

@vitaliidm vitaliidm self-assigned this Jul 24, 2024
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.16.0 labels Jul 24, 2024
@vitaliidm vitaliidm marked this pull request as ready for review July 24, 2024 09:07
@vitaliidm vitaliidm requested review from a team as code owners July 24, 2024 09:08
@vitaliidm vitaliidm requested a review from nkhristinin July 24, 2024 09:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@vitaliidm vitaliidm enabled auto-merge (squash) July 25, 2024 08:44
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB -61.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.2KB 86.2KB -40.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit a8e19ee into main Jul 25, 2024
40 checks passed
@vitaliidm vitaliidm deleted the de_8_16/ai-ff branch July 25, 2024 10:24
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

@janmonschke janmonschke janmonschke approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitaliidm @elasticmachine @kibana-ci @janmonschke @nkhristinin @kibanamachine