[Security Solution][Detection Engine] removes feature flag for AI ass…

…istant on rule create form (#189040) ## Summary - removes feature flag AIAssistantOnRuleCreationFormEnabled
elastic · Jul 25, 2024 · a8e19ee · a8e19ee
1 parent fb34fc7
commit a8e19ee
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 30 deletions.
diff --git a/x-pack/plugins/security_solution/common/experimental_features.ts b/x-pack/plugins/security_solution/common/experimental_features.ts
@@ -158,11 +158,6 @@ export const allowedExperimentalValues = Object.freeze({
    */
   protectionUpdatesEnabled: true,
 
-  /**
-   * Enables AI assistant on rule creation form when query has error
-   */
-  AIAssistantOnRuleCreationFormEnabled: false,
-
   /**
    * Disables the timeline save tour.
    * This flag is used to disable the tour in cypress tests.

diff --git a/...ution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.test.tsx b/...ution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.test.tsx
@@ -25,7 +25,6 @@ import {
   createIndexPatternField,
   getSelectToggleButtonForName,
 } from '../../../rule_creation/components/required_fields/required_fields.test';
-import { useIsExperimentalFeatureEnabled } from '../../../../common/hooks/use_experimental_features';
 
 // Mocks integrations
 jest.mock('../../../fleet_integrations/api');
@@ -49,11 +48,6 @@ jest.mock('../ai_assistant', () => {
   };
 });
 
-jest.mock('../../../../common/hooks/use_experimental_features', () => ({
-  useIsExperimentalFeatureEnabled: jest.fn(),
-}));
-
-const useIsExperimentalFeatureEnabledMock = useIsExperimentalFeatureEnabled as jest.Mock;
 const mockRedirectLegacyUrl = jest.fn();
 const mockGetLegacyUrlConflict = jest.fn();
 jest.mock('../../../../common/lib/kibana', () => {
@@ -631,9 +625,6 @@ describe('StepDefineRule', () => {
   });
 
   describe('AI assistant', () => {
-    beforeEach(() => {
-      useIsExperimentalFeatureEnabledMock.mockReturnValue(true);
-    });
     it('renders assistant when query is not valid', () => {
       render(<TestForm formProps={{ isQueryBarValid: false, ruleType: 'query' }} />, {
         wrapper: TestProviders,
@@ -642,16 +633,6 @@ describe('StepDefineRule', () => {
       expect(screen.getByTestId('ai-assistant')).toBeInTheDocument();
     });
 
-    it('does not render assistant when feature flag is disabled', () => {
-      useIsExperimentalFeatureEnabledMock.mockReturnValue(false);
-
-      render(<TestForm formProps={{ isQueryBarValid: false, ruleType: 'query' }} />, {
-        wrapper: TestProviders,
-      });
-
-      expect(screen.queryByTestId('ai-assistant')).toBe(null);
-    });
-
     it('does not render assistant when query is valid', () => {
       render(<TestForm formProps={{ isQueryBarValid: true, ruleType: 'query' }} />, {
         wrapper: TestProviders,

diff --git a/...y_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.tsx b/...y_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.tsx
@@ -54,7 +54,6 @@ import { MlJobSelect } from '../../../rule_creation/components/ml_job_select';
 import { PickTimeline } from '../../../rule_creation/components/pick_timeline';
 import { StepContentWrapper } from '../../../rule_creation/components/step_content_wrapper';
 import { ThresholdInput } from '../threshold_input';
-import { useIsExperimentalFeatureEnabled } from '../../../../common/hooks/use_experimental_features';
 import { SuppressionInfoIcon } from '../suppression_info_icon';
 import { EsqlInfoIcon } from '../../../rule_creation/components/esql_info_icon';
 import {
@@ -216,10 +215,6 @@ const StepDefineRuleComponent: FC<StepDefineRuleProps> = ({
 
   const isThresholdRule = getIsThresholdRule(ruleType);
   const alertSuppressionUpsellingMessage = useUpsellingMessage('alert_suppression_rule_form');
-
-  const isAIAssistantEnabled = useIsExperimentalFeatureEnabled(
-    'AIAssistantOnRuleCreationFormEnabled'
-  );
   const { getFields, reset, setFieldValue } = form;
 
   const setRuleTypeCallback = useSetFieldValueWithCallback({
@@ -938,7 +933,7 @@ const StepDefineRuleComponent: FC<StepDefineRuleProps> = ({
             </>
           </RuleTypeEuiFormRow>
 
-          {isAIAssistantEnabled && !isMlRule(ruleType) && !isQueryBarValid && (
+          {!isMlRule(ruleType) && !isQueryBarValid && (
             <AiAssistant getFields={form.getFields} language={queryBar?.query?.language} />
           )}