Remove re2 library
#186155
Remove re2 library
#186155
Conversation
|
/ci |
pgayvallet
added
release_note:skip
| RE2_DOWNLOAD_MIRROR: | ||
| 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2', | ||
| }, | ||
| env: {}, |
There was a problem hiding this comment.
kept the entry, tell me if I should remove env: {} altogether.
| }, | ||
| }, | ||
| ]; | ||
| const packages: Package[] = []; |
There was a problem hiding this comment.
Kept the empty array and the task, in case we may need to re-add more native modules at some point.
Please tell me if I should fully remove that task instead.
|
/ci |
|
@pgayvallet I will pickup this PR next week and evolve it in the lines of https://github.com/elastic/kibana-operations/issues/131 as I've agreed this yesterday with Luke and Brandon |
|
@mistic sounds good. Will you take over my PR or should I close it? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
@pgayvallet I will cherrypick what you have on your branch but will probably open a new one as I don't know when I will fully complete it (probably somewhere next week) |
|
Sounds good - closing then |
Summary
After #186104, get rid of the last usage of
re2in code and in tooling