[ML] Removes use of re2 library #186104
Merged
[ML] Removes use of re2 library #186104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
Closed
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jul 15, 2024
We no longer need to use `re2` over the standard regex library. (cherry picked from commit ed70d4c)
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jul 15, 2024
We no longer need to use `re2` over the standard regex library. (cherry picked from commit ed70d4c) # Conflicts: # x-pack/plugins/ml/server/saved_objects/initialization/space_overrides/logs.ts # x-pack/plugins/ml/server/saved_objects/initialization/space_overrides/metrics.ts # x-pack/plugins/ml/server/saved_objects/service.ts
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
Jul 16, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[ML] Removing use of re2 library (#186104)](#186104) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-13T05:43:40Z","message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","backport:skip","v8.15.0"],"number":186104,"url":"https://github.com/elastic/kibana/pull/186104","mergeCommit":{"message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186104","number":186104,"mergeCommit":{"message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
mistic
added a commit
that referenced
this pull request
Jul 16, 2024
# Backport This will backport the following commits from `main` to `7.17`: - [[ML] Removing use of re2 library (#186104)](#186104) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-13T05:43:40Z","message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","backport:skip","v8.15.0"],"number":186104,"url":"https://github.com/elastic/kibana/pull/186104","mergeCommit":{"message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186104","number":186104,"mergeCommit":{"message":"[ML] Removing use of re2 library (#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}}]}] BACKPORT--> --------- Co-authored-by: James Gowdy <[email protected]>
szabosteve
changed the title
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
) # Backport This will backport the following commits from `main` to `7.17`: - [[ML] Removing use of re2 library (elastic#186104)](elastic#186104) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-13T05:43:40Z","message":"[ML] Removing use of re2 library (elastic#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","backport:skip","v8.15.0"],"number":186104,"url":"https://github.com/elastic/kibana/pull/186104","mergeCommit":{"message":"[ML] Removing use of re2 library (elastic#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186104","number":186104,"mergeCommit":{"message":"[ML] Removing use of re2 library (elastic#186104)\n\nWe no longer need to use `re2` over the standard regex library.","sha":"ed70d4c6ffb77324f9c6e74e26ed559303ae6c3f"}}]}] BACKPORT--> --------- Co-authored-by: James Gowdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to use
re2over the standard regex library.