Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Investigations] - Limit sample size range input to integers #185998

Merged

Conversation

michaelolo24
Copy link
Contributor

Summary

Currently you can enter a decimal value in the sample size range selector which causes an error in the discover experience. This ticket resolves that issue by limiting the actual parsed value to an integer.

Original bug: #184708

@michaelolo24 michaelolo24 added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0 labels Jun 11, 2024
@michaelolo24 michaelolo24 requested a review from a team as a code owner June 11, 2024 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@michaelolo24 michaelolo24 force-pushed the fix-unified-table-sample-size-range branch from 65b68e2 to 0379b7a Compare June 12, 2024 14:58
@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@michaelolo24
Copy link
Contributor Author

/ci

1 similar comment
@michaelolo24
Copy link
Contributor Author

/ci

@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@michaelolo24
Copy link
Contributor Author

/ci

@michaelolo24 michaelolo24 force-pushed the fix-unified-table-sample-size-range branch from 0ad9097 to 5fc208e Compare June 13, 2024 13:49
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 450.1KB 450.2KB +39.0B
discover 809.2KB 809.3KB +39.0B
esqlDataGrid 118.7KB 118.7KB +39.0B
securitySolution 13.6MB 13.6MB +195.0B
slo 860.6KB 860.6KB +39.0B
total +351.0B

History

  • 💔 Build #215763 failed 0ad909710d6c3e484aab5e347c65a6c593e46784
  • 💔 Build #215474 failed 65b68e291a5ab5ffccae9ef9192f0494009159a3
  • 💛 Build #215266 was flaky 73987cb156fda7a3217fbe037d5b53469dd42e2f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24 michaelolo24 merged commit 8c7a36f into elastic:main Jun 13, 2024
17 of 18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2024
@michaelolo24 michaelolo24 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants