-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Investigations] - Limit sample size range input to integers #185998
Merged
michaelolo24
merged 1 commit into
elastic:main
from
michaelolo24:fix-unified-table-sample-size-range
Jun 13, 2024
Merged
[Bug][Investigations] - Limit sample size range input to integers #185998
michaelolo24
merged 1 commit into
elastic:main
from
michaelolo24:fix-unified-table-sample-size-range
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
bug
Fixes for quality problems that affect the customer experience
release_note:fix
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.15.0
labels
Jun 11, 2024
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
lukasolson
approved these changes
Jun 11, 2024
@elasticmachine merge upstream |
michaelolo24
force-pushed
the
fix-unified-table-sample-size-range
branch
from
June 12, 2024 14:58
65b68e2
to
0379b7a
Compare
@elasticmachine merge upstream |
/ci |
1 similar comment
/ci |
@elasticmachine merge upstream |
/ci |
michaelolo24
force-pushed
the
fix-unified-table-sample-size-range
branch
from
June 13, 2024 13:49
0ad9097
to
5fc208e
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
michaelolo24
added
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:fix
labels
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently you can enter a decimal value in the sample size range selector which causes an error in the discover experience. This ticket resolves that issue by limiting the actual parsed value to an integer.
Original bug: #184708