Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Unified Timeline]error on changing the spanning size manually and not from down and up arrow ( used decimal value also ) #184708

Closed
ghost opened this issue Jun 4, 2024 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team
Milestone

Comments

@ghost
Copy link

ghost commented Jun 4, 2024

Describe the bug:
[Timeline]error on changing the spanning size manually and not from down and up arrow ( used decimal value also )

Kibana/Elasticsearch Stack version

Version: SNAPSHOT
Commit: 10f61743ad0a73d3814f9d78c9dd1511e08fa195
Build: 75077

precondition

  • NA

Steps to reproduce

  • Navigate to Security > Timeline
  • Create Timeline with valid query
  • change Spanning Size manually and try using float value
  • Observed that error on changing the spanning size manually and not from down and up arrow ( used decimal value also )

Current Result

  • [Timeline] error on changing the spanning size manually and not from down and up arrow ( used decimal value also )

Expected Result

  • [Timeline]No Error should receive on manually changing spanning size

Screen-cast

Timelines.-.Kibana.Mozilla.Firefox.2024-05-30.17-16-12.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jun 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned MadameSheema and unassigned amolnater-qasource Jun 4, 2024
@MadameSheema MadameSheema added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Jun 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@MadameSheema MadameSheema assigned logeekal and unassigned MadameSheema Jun 4, 2024
@logeekal logeekal added the Feature:Timeline Security Solution Timeline feature label Jun 6, 2024
@logeekal logeekal changed the title [Security Solution][Timeline]error on changing the spanning size manually and not from down and up arrow ( used decimal value also ) [Security Solution][Unified Timeline]error on changing the spanning size manually and not from down and up arrow ( used decimal value also ) Jun 6, 2024
@logeekal logeekal added this to the 8.15 milestone Jun 6, 2024
@logeekal logeekal removed their assignment Jun 6, 2024
@logeekal
Copy link
Contributor

@karanbirsingh-qasource , Thanks for raising this bug. I have one question. I can see that the error only occurs when you use decimal value.

I can also see that table is working with values of 5 and 210 which were manually entered. Let me know if my assessment is correct.

@ghost
Copy link
Author

ghost commented Jun 11, 2024

right issue occurred once we entered the decimal value

@michaelolo24
Copy link
Contributor

@karanbirsingh-qasource and @logeekal the issue occurs when you enter a non-integer value. Entering an integer (decimal or no decimal) 2, 5.00, 12.0 all work fine, but if you enter a non-integer 2.3 or 2.2 the query fails.

@michaelolo24 michaelolo24 self-assigned this Jun 11, 2024
michaelolo24 added a commit that referenced this issue Jun 13, 2024
…85998)

## Summary

Currently you can enter a decimal value in the sample size range
selector which causes an error in the discover experience. This ticket
resolves that issue by limiting the actual parsed value to an integer.

Original bug: #184708
@michaelolo24
Copy link
Contributor

@karanbirsingh-qasource the issue should no longer occur now if you can retest on main. Thanks!

@logeekal logeekal added the fixed label Jun 17, 2024
@ghost
Copy link
Author

ghost commented Jun 17, 2024

Hi @michaelolo24

we have validated this issue on 8.15-SNAPSHOT and found this issue to be fixed now.

Build Details:

Version: 8.15.0-SNAPSHOT
Commit: 13382875e99e8c97f4574d86eca07cac3be9edfc
Build: 75422

screen-cast:

Timelines.-.Kibana.Mozilla.Firefox.2024-06-17.17-23-30.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed Jun 17, 2024
@ghost ghost added the QA:Validated Issue has been validated by QA label Jun 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

No branches or pull requests

5 participants