-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops][Rule Form V2] Move dependencies from triggers actions UI to shared package #184977
[Response Ops][Rule Form V2] Move dependencies from triggers actions UI to shared package #184977
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving all this code to the alerts-ui-shared
package will grow its size by a lot and also the bundle size of plugins that consume it. I suggest splitting up the code into multiple packages by following the new convention outlined in the dev docs.
- packages/response-ops
- hooks-browser (@kbn/response-ops-hooks-browser)
- api-browser (@kbn/response-ops-api-browser)
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We discussed offline that we will come up with a naming convention and strategy for our packages before splitting the alerts-ui-shared
package into multiple ones.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Issue: #179105
Related PR: #180539
Part 2.5/3 PRs of the new rule form. This PR acts as the foundation PR for the main rule form PR by moving a lot of the dependencies needed by the rules form to a shared package. So no new features added, just moving stuff around.
Checklist