[RAM] [Rule Form V2] Add full-page create/edit form behind feature flag to Stack Management #180539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llpage # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx
Zacqary
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
…y/kibana into 179105-rule-form-fullpage
Ported over in latest commit |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This was referenced May 13, 2024
JiaweiWu
added a commit
that referenced
this pull request
May 31, 2024
## Summary Issue: #179105 Related PR: #180539 Part 1 of 3 PRs of new rule form. This PR extracts the first section of the rule form, the rule definition, from the original PR. The purpose is to fix a few bugs (Such as improving the alert delay and the rule schedule input validation), and also try to make the PR much smaller for review. The design philosophy in the PR is to create components that are devoid of any fetching or form logic. These are simply dumb components. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with `yarn start --run-examples` 2. Navigate to `http://localhost:5601/app/triggersActionsUiExample/rule_definition` And you should be able to play around with the components in this PR: <img width="1257" alt="Screenshot 2024-05-13 at 10 10 51 AM" src="https://github.com/elastic/kibana/assets/74562234/a1ab6d96-946d-4bf6-94e2-6aa903d0b8f5"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Zacqary <[email protected]> Co-authored-by: kibanamachine <[email protected]>
JiaweiWu
added a commit
that referenced
this pull request
Jun 5, 2024
## Summary Issue: #179105 Related PR: #180539 Part 1: #183325 Part 2 of 3 PRs of new rule form. This PR depends on the code from part 1, so only merge this when part 1 has been merged. This PR extracts the last section of the rule form, the rule details, from the original PR. The design philosophy in the PR is to create components that are devoid of any fetching or form logic. These are simply dumb components. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with yarn start --run-examples 2. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule_details And you should be able to play around with the components in this PR: <img width="1281" alt="Screenshot 2024-05-13 at 9 44 14 PM" src="https://github.com/elastic/kibana/assets/74562234/7ca900e3-ca9a-4810-8b24-7c3ea41055d6"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Zacqary <[email protected]> Co-authored-by: kibanamachine <[email protected]>
This was referenced Jun 6, 2024
JiaweiWu
added a commit
that referenced
this pull request
Jun 12, 2024
…UI to shared package (#184977) ## Summary Issue: #179105 Related PR: #180539 Part 2.5/3 PRs of the new rule form. This PR acts as the foundation PR for the main rule form PR by moving a lot of the dependencies needed by the rules form to a shared package. So no new features added, just moving stuff around. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
1 task
JiaweiWu
added a commit
that referenced
this pull request
Jul 4, 2024
…anagement (#184892) ## Summary Issue: #179105 Related PR: #180539 Part 3/3 PRs of the new rule form. This PR adds the create and edit rule page as well as the state management using react reducers. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with yarn start --run-examples 2. Navigate to `http://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId>` (I use `.es-query`) 3. Create a rule 4. Navigate to `http://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId>` with the rule you just created to edit the rule <img width="1196" alt="Screenshot 2024-05-14 at 8 27 00 PM" src="https://github.com/elastic/kibana/assets/74562234/576fecdd-bd7b-4cad-a3db-aab3163abc46"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
|
Rule form V2 work has moved to a series of other PRs, closing this one |
JiaweiWu
added a commit
that referenced
this pull request
Sep 27, 2024
…Form (#187434) ## Summary Issue: #179105 Related PR: #180539 Final PR of the rule actions V2 PR (2/2 of the actions PRs). This PR contains the actions modal and actions form. This PR depends on #186490. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with yarn start --run-examples 2. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId> (I use .es-query) 3. Create a rule 4. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId> with the rule you just created to edit the rule <img width="1236" alt="Screenshot 2024-07-02 at 5 15 51 PM" src="https://github.com/elastic/kibana/assets/74562234/1dc5d2a9-804a-4861-94ba-814de73dc3ab">  <img width="1087" alt="Screenshot 2024-07-02 at 5 15 58 PM" src="https://github.com/elastic/kibana/assets/74562234/903e66b5-f9a1-4d09-b121-b1dcecdff72c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2024
…Form (elastic#187434) ## Summary Issue: elastic#179105 Related PR: elastic#180539 Final PR of the rule actions V2 PR (2/2 of the actions PRs). This PR contains the actions modal and actions form. This PR depends on elastic#186490. I have also created a example plugin to demonstrate this PR. To access: 1. Run the branch with yarn start --run-examples 2. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId> (I use .es-query) 3. Create a rule 4. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId> with the rule you just created to edit the rule <img width="1236" alt="Screenshot 2024-07-02 at 5 15 51 PM" src="https://github.com/elastic/kibana/assets/74562234/1dc5d2a9-804a-4861-94ba-814de73dc3ab">  <img width="1087" alt="Screenshot 2024-07-02 at 5 15 58 PM" src="https://github.com/elastic/kibana/assets/74562234/903e66b5-f9a1-4d09-b121-b1dcecdff72c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 54659e8)
kibanamachine
referenced
this pull request
Sep 27, 2024
…tions Form (#187434) (#194254) # Backport This will backport the following commits from `main` to `8.x`: - [[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form (#187434)](#187434) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T06:34:27Z","message":"[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form (#187434)\n\n## Summary\r\nIssue: https://github.com/elastic/kibana/issues/179105\r\nRelated PR: https://github.com/elastic/kibana/pull/180539\r\n\r\nFinal PR of the rule actions V2 PR (2/2 of the actions PRs). This PR\r\ncontains the actions modal and actions form. This PR depends on\r\nhttps://github.com//pull/186490.\r\n\r\nI have also created a example plugin to demonstrate this PR. To access:\r\n\r\n1. Run the branch with yarn start --run-examples\r\n2. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId>\r\n(I use .es-query)\r\n3. Create a rule\r\n4. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId>\r\nwith the rule you just created to edit the rule\r\n\r\n<img width=\"1236\" alt=\"Screenshot 2024-07-02 at 5 15 51 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/1dc5d2a9-804a-4861-94ba-814de73dc3ab\">\r\n\r\n\r\n\r\n<img width=\"1087\" alt=\"Screenshot 2024-07-02 at 5 15 58 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/903e66b5-f9a1-4d09-b121-b1dcecdff72c\">\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"54659e8ae002aa68be3ee472ef12b3d3f546a1ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form","number":187434,"url":"https://github.com/elastic/kibana/pull/187434","mergeCommit":{"message":"[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form (#187434)\n\n## Summary\r\nIssue: https://github.com/elastic/kibana/issues/179105\r\nRelated PR: https://github.com/elastic/kibana/pull/180539\r\n\r\nFinal PR of the rule actions V2 PR (2/2 of the actions PRs). This PR\r\ncontains the actions modal and actions form. This PR depends on\r\nhttps://github.com//pull/186490.\r\n\r\nI have also created a example plugin to demonstrate this PR. To access:\r\n\r\n1. Run the branch with yarn start --run-examples\r\n2. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId>\r\n(I use .es-query)\r\n3. Create a rule\r\n4. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId>\r\nwith the rule you just created to edit the rule\r\n\r\n<img width=\"1236\" alt=\"Screenshot 2024-07-02 at 5 15 51 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/1dc5d2a9-804a-4861-94ba-814de73dc3ab\">\r\n\r\n\r\n\r\n<img width=\"1087\" alt=\"Screenshot 2024-07-02 at 5 15 58 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/903e66b5-f9a1-4d09-b121-b1dcecdff72c\">\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"54659e8ae002aa68be3ee472ef12b3d3f546a1ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187434","number":187434,"mergeCommit":{"message":"[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form (#187434)\n\n## Summary\r\nIssue: https://github.com/elastic/kibana/issues/179105\r\nRelated PR: https://github.com/elastic/kibana/pull/180539\r\n\r\nFinal PR of the rule actions V2 PR (2/2 of the actions PRs). This PR\r\ncontains the actions modal and actions form. This PR depends on\r\nhttps://github.com//pull/186490.\r\n\r\nI have also created a example plugin to demonstrate this PR. To access:\r\n\r\n1. Run the branch with yarn start --run-examples\r\n2. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/create/<ruleTypeId>\r\n(I use .es-query)\r\n3. Create a rule\r\n4. Navigate to\r\nhttp://localhost:5601/app/triggersActionsUiExample/rule/edit/<ruleId>\r\nwith the rule you just created to edit the rule\r\n\r\n<img width=\"1236\" alt=\"Screenshot 2024-07-02 at 5 15 51 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/1dc5d2a9-804a-4861-94ba-814de73dc3ab\">\r\n\r\n\r\n\r\n<img width=\"1087\" alt=\"Screenshot 2024-07-02 at 5 15 58 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/74562234/903e66b5-f9a1-4d09-b121-b1dcecdff72c\">\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"54659e8ae002aa68be3ee472ef12b3d3f546a1ea"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jiawei Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #179105
Rule Form V2 is now accessible from Stack Management by adding this to
kibana.yml:Actions cannot yet be configured. These will be added in #179106 and #179107
Create and Edit
This full page form works both for creating new rules and editing existing ones. It can be accessed using the existing UI, or using the new routes
rule/create/:ruleTypeIdandrule/edit/:ruleId.Expression validation
Error messages from the expression component affect the overall form validation.
Known broken rule types
V2 contains breaking changes for the following rule type expression components:
These should be fairly simple errors to fix, and we can include them in a further PR where we add this rule form to Observability.
Checklist
Delete any items that are not applicable to this PR.