Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless][Observability] Use role-based testing - functional #184823

Merged
merged 5 commits into from
Jun 7, 2024
Merged

[Serverless][Observability] Use role-based testing - functional #184823

merged 5 commits into from
Jun 7, 2024

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Jun 5, 2024 •
edited
Loading

part of: #184033

Summary

This PR changes the observability serverless tests to not run with operator privileges.

How to test

@crespocarlos
Copy link
Contributor Author

/ci

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos changed the title [Serverless][Observability] Use user roles - functional [Serverless][Observability] Use role-based testing - functional Jun 5, 2024
@crespocarlos crespocarlos force-pushed the 184033-functional-user-roles branch from bc2ec7b to 8cb9e3b Compare June 5, 2024 11:27
@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 labels Jun 5, 2024
This was referenced Jun 5, 2024
Closed
Open
@crespocarlos crespocarlos force-pushed the 184033-functional-user-roles branch 2 times, most recently from 5cdb3ef to 4fab782 Compare June 6, 2024 09:40
@crespocarlos crespocarlos force-pushed the 184033-functional-user-roles branch from 4fab782 to 48c78a2 Compare June 6, 2024 14:18
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos marked this pull request as ready for review June 6, 2024 20:39
@crespocarlos crespocarlos requested review from a team as code owners June 6, 2024 20:39
tonyghiani
tonyghiani approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs logs explorer changes LGTM, thanks for this!

jgowdyelastic
jgowdyelastic approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos crespocarlos enabled auto-merge (squash) June 7, 2024 14:41
@crespocarlos crespocarlos disabled auto-merge June 7, 2024 14:57
@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit c7d6823 into elastic:main Jun 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@cnasikas cnasikas cnasikas approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@crespocarlos @apmmachine @kibana-ci @sabarasaba @cnasikas @jgowdyelastic @tonyghiani @kibanamachine