[Serverless][Observability] Use role-based testing - functional (#184823

) part of: [#184033](#184033) ## Summary This PR changes the observability serverless tests to not run with operator privileges. ### How to test - Follow the steps from https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki --------- Co-authored-by: Kibana Machine <[email protected]>
elastic · Jun 7, 2024 · c7d6823 · c7d6823
1 parent f87eccf
commit c7d6823
Show file tree

Hide file tree

Showing 26 changed files with 101 additions and 91 deletions.
diff --git a/x-pack/test_serverless/functional/test_suites/observability/advanced_settings.ts b/x-pack/test_serverless/functional/test_suites/observability/advanced_settings.ts
@@ -18,7 +18,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
   describe('Observability advanced settings', function () {
     before(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('admin');
       await pageObjects.common.navigateToApp('settings');
     });
 

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts
@@ -26,7 +26,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
   describe('Cases persistable attachments', function () {
     describe('lens visualization', () => {
       before(async () => {
-        await svlCommonPage.login();
+        await svlCommonPage.loginWithRole('admin');
         await kibanaServer.savedObjects.cleanStandardList();
         await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
         await kibanaServer.importExport.load(

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts
@@ -23,7 +23,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
 
   describe('Configure Case', function () {
     before(async () => {
-      await svlCommonPage.login();
+      await svlCommonPage.loginWithRole('admin');
       await svlObltNavigation.navigateToLandingPage();
       await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'observability-overview:cases' });
       await header.waitUntilLoadingHasFinished();

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/create_case_form.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/create_case_form.ts
@@ -25,7 +25,7 @@ export default ({ getService, getPageObject }: FtrProviderContext) => {
     const header = getPageObject('header');
 
     before(async () => {
-      await svlCommonPage.login();
+      await svlCommonPage.loginWithRole('admin');
     });
 
     beforeEach(async () => {

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/list_view.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/list_view.ts
@@ -21,7 +21,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
 
   describe('Cases list', function () {
     before(async () => {
-      await svlCommonPage.login();
+      await svlCommonPage.loginWithRole('admin');
       await svlObltNavigation.navigateToLandingPage();
       await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'observability-overview:cases' });
     });

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts
@@ -36,7 +36,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
 
   describe('Case View', function () {
     before(async () => {
-      await svlCommonPage.login();
+      await svlCommonPage.loginWithRole('admin');
     });
 
     after(async () => {

diff --git a/x-pack/test_serverless/functional/test_suites/observability/infra/header_menu.ts b/x-pack/test_serverless/functional/test_suites/observability/infra/header_menu.ts
@@ -16,7 +16,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   describe('Header menu', () => {
     before(async () => {
       await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
     after(async () => {

diff --git a/x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts b/x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts
@@ -45,7 +45,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await Promise.all([
         esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
       ]);
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('viewer');
       await browser.setWindowSize(1600, 1200);
     });
 

diff --git a/x-pack/test_serverless/functional/test_suites/observability/infra/infra.ts b/x-pack/test_serverless/functional/test_suites/observability/infra/infra.ts
@@ -31,7 +31,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
   describe('Infra pages', function () {
     before(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
     after(async () => {

diff --git a/x-pack/test_serverless/functional/test_suites/observability/infra/navigation.ts b/x-pack/test_serverless/functional/test_suites/observability/infra/navigation.ts
@@ -26,7 +26,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
   describe('Infra Side Navigation', () => {
     before(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('viewer');
       await svlObltNavigation.navigateToLandingPage();
     });
 

diff --git a/x-pack/test_serverless/functional/test_suites/observability/infra/node_details.ts b/x-pack/test_serverless/functional/test_suites/observability/infra/node_details.ts
@@ -35,7 +35,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       before(async () => {
         await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
 
-        await pageObjects.svlCommonPage.login();
+        await pageObjects.svlCommonPage.loginWithRole('viewer');
         await pageObjects.common.navigateToApp(
           `metrics/${NODE_DETAILS_PATH}/demo-stack-kubernetes-01`
         );

diff --git a/...ck/test_serverless/functional/test_suites/observability/ml/anomaly_detection_jobs_list.ts b/...ck/test_serverless/functional/test_suites/observability/ml/anomaly_detection_jobs_list.ts
@@ -19,7 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     // Error: Failed to delete all indices with pattern [.ml-*]
     this.tags(['failsOnMKI']);
     before(async () => {
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('admin');
 
       // Load logstash* data and create dataview for logstash*, logstash-2015.09.22
       await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');

diff --git a/x-pack/test_serverless/functional/test_suites/observability/ml/search_bar_features.ts b/x-pack/test_serverless/functional/test_suites/observability/ml/search_bar_features.ts
@@ -10,80 +10,90 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
 export default function ({ getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects(['header', 'svlCommonPage', 'svlCommonNavigation']);
 
-  const allLabels = [
-    { label: 'Machine Learning', expected: true },
-    { label: 'Machine Learning / Overview', expected: true },
-    { label: 'Machine Learning / Anomaly Detection', expected: true },
-    { label: 'Machine Learning / Anomaly Detection / Anomaly explorer', expected: true },
-    { label: 'Machine Learning / Anomaly Detection / Single metric viewer', expected: true },
-    { label: 'Machine Learning / Data Frame Analytics', expected: false },
-    { label: 'Machine Learning / Data Frame Analytics / Results explorer', expected: false },
-    { label: 'Machine Learning / Data Frame Analytics / Analytics map', expected: false },
-    { label: 'Machine Learning / Model Management', expected: true },
-    { label: 'Machine Learning / Model Management / Trained Models', expected: true },
-    { label: 'Machine Learning / Model Management / Nodes', expected: false },
-    { label: 'Machine Learning / Memory Usage', expected: true },
-    { label: 'Machine Learning / Settings', expected: true },
-    { label: 'Machine Learning / Settings / Calendars', expected: true },
-    { label: 'Machine Learning / Settings / Filter Lists', expected: true },
-    { label: 'Machine Learning / AIOps', expected: true },
-    { label: 'Machine Learning / AIOps / Log Rate Analysis', expected: true },
-    { label: 'Machine Learning / AIOps / Log Pattern Analysis', expected: true },
-    { label: 'Machine Learning / AIOps / Change Point Detection', expected: true },
-    { label: 'Machine Learning / Notifications', expected: true },
-    { label: 'Machine Learning / Data Visualizer', expected: true },
-    { label: 'Machine Learning / File Upload', expected: true },
-    { label: 'Machine Learning / Index Data Visualizer', expected: true },
-    { label: 'Machine Learning / ES|QL Data Visualizer', expected: true },
-    { label: 'Machine Learning / Data Drift', expected: true },
-    { label: 'Alerts and Insights / Machine Learning', expected: true },
-  ];
+  const allLabels = {
+    viewer: [
+      { label: 'Machine Learning', expected: true },
+      { label: 'Machine Learning / Overview', expected: true },
+      { label: 'Machine Learning / Anomaly Detection', expected: true },
+      { label: 'Machine Learning / Anomaly Detection / Anomaly explorer', expected: true },
+      { label: 'Machine Learning / Anomaly Detection / Single metric viewer', expected: true },
+      { label: 'Machine Learning / Data Frame Analytics', expected: false },
+      { label: 'Machine Learning / Data Frame Analytics / Results explorer', expected: false },
+      { label: 'Machine Learning / Data Frame Analytics / Analytics map', expected: false },
+      { label: 'Machine Learning / Model Management', expected: true },
+      { label: 'Machine Learning / Model Management / Trained Models', expected: true },
+      { label: 'Machine Learning / Model Management / Nodes', expected: false },
+      { label: 'Machine Learning / Memory Usage', expected: true },
+      { label: 'Machine Learning / Settings', expected: true },
+      { label: 'Machine Learning / Settings / Calendars', expected: true },
+      { label: 'Machine Learning / Settings / Filter Lists', expected: true },
+      { label: 'Machine Learning / AIOps', expected: true },
+      { label: 'Machine Learning / AIOps / Log Rate Analysis', expected: true },
+      { label: 'Machine Learning / AIOps / Log Pattern Analysis', expected: true },
+      { label: 'Machine Learning / AIOps / Change Point Detection', expected: true },
+      { label: 'Machine Learning / Notifications', expected: true },
+      { label: 'Machine Learning / Data Visualizer', expected: true },
+      { label: 'Machine Learning / File Upload', expected: true },
+      { label: 'Machine Learning / Index Data Visualizer', expected: true },
+      { label: 'Machine Learning / ES|QL Data Visualizer', expected: true },
+      { label: 'Machine Learning / Data Drift', expected: true },
+    ],
+    admin: [{ label: 'Alerts and Insights / Machine Learning', expected: true }],
+  };
 
   describe('Search bar features', () => {
-    before(async () => {
-      await PageObjects.svlCommonPage.login();
-    });
+    ([{ role: 'viewer' }, { role: 'admin' }] as Array<{ role: keyof typeof allLabels }>).forEach(
+      ({ role }) => {
+        describe(`user role: ${role}`, () => {
+          before(async () => {
+            await PageObjects.svlCommonPage.loginWithRole(role);
+          });
 
-    after(async () => {
-      await PageObjects.svlCommonPage.forceLogout();
-    });
+          after(async () => {
+            await PageObjects.svlCommonPage.forceLogout();
+          });
 
-    describe('list features', () => {
-      it('has the correct features enabled', async () => {
-        await PageObjects.header.waitUntilLoadingHasFinished();
-        await PageObjects.svlCommonNavigation.search.showSearch();
+          describe('list features', () => {
+            it('has the correct features enabled', async () => {
+              await PageObjects.header.waitUntilLoadingHasFinished();
+              await PageObjects.svlCommonNavigation.search.showSearch();
 
-        const expectedLabels = allLabels.filter((l) => l.expected).map((l) => l.label);
+              const expectedLabels = allLabels[role].filter((l) => l.expected).map((l) => l.label);
 
-        for (const expectedLabel of expectedLabels) {
-          await PageObjects.svlCommonNavigation.search.searchFor(expectedLabel);
-          const [result] = await PageObjects.svlCommonNavigation.search.getDisplayedResults();
-          const label = result?.label;
-          expect(label).to.eql(
-            expectedLabel,
-            `First result should be ${expectedLabel} (got matching items '${label}')`
-          );
-        }
-        await PageObjects.svlCommonNavigation.search.hideSearch();
-      });
+              for (const expectedLabel of expectedLabels) {
+                await PageObjects.svlCommonNavigation.search.searchFor(expectedLabel);
+                const [result] = await PageObjects.svlCommonNavigation.search.getDisplayedResults();
+                const label = result?.label;
+                expect(label).to.eql(
+                  expectedLabel,
+                  `First result should be ${expectedLabel} (got matching items '${label}')`
+                );
+              }
+              await PageObjects.svlCommonNavigation.search.hideSearch();
+            });
 
-      it('has the correct features disabled', async () => {
-        await PageObjects.header.waitUntilLoadingHasFinished();
-        await PageObjects.svlCommonNavigation.search.showSearch();
+            it('has the correct features disabled', async () => {
+              await PageObjects.header.waitUntilLoadingHasFinished();
+              await PageObjects.svlCommonNavigation.search.showSearch();
 
-        const notExpectedLabels = allLabels.filter((l) => !l.expected).map((l) => l.label);
+              const notExpectedLabels = allLabels[role]
+                .filter((l) => !l.expected)
+                .map((l) => l.label);
 
-        for (const notExpectedLabel of notExpectedLabels) {
-          await PageObjects.svlCommonNavigation.search.searchFor(notExpectedLabel);
-          const [result] = await PageObjects.svlCommonNavigation.search.getDisplayedResults();
-          const label = result?.label;
-          expect(label).to.not.eql(
-            notExpectedLabel,
-            `First result should not be ${notExpectedLabel} (got matching items '${label}')`
-          );
-        }
-        await PageObjects.svlCommonNavigation.search.hideSearch();
-      });
-    });
+              for (const notExpectedLabel of notExpectedLabels) {
+                await PageObjects.svlCommonNavigation.search.searchFor(notExpectedLabel);
+                const [result] = await PageObjects.svlCommonNavigation.search.getDisplayedResults();
+                const label = result?.label;
+                expect(label).to.not.eql(
+                  notExpectedLabel,
+                  `First result should not be ${notExpectedLabel} (got matching items '${label}')`
+                );
+              }
+              await PageObjects.svlCommonNavigation.search.hideSearch();
+            });
+          });
+        });
+      }
+    );
   });
 }
diff --git a/...ess/functional/test_suites/observability/observability_logs_explorer/columns_selection.ts b/...ess/functional/test_suites/observability/observability_logs_explorer/columns_selection.ts
@@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   describe('When the logs explorer loads', () => {
     before(async () => {
       await synthtrace.index(generateLogsData({ to }));
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await navigateToLogsExplorer();
     });
 

diff --git a/...unctional/test_suites/observability/observability_logs_explorer/custom_control_columns.ts b/...unctional/test_suites/observability/observability_logs_explorer/custom_control_columns.ts
@@ -36,7 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   describe('When the logs explorer loads', () => {
     before(async () => {
       await synthtrace.index(generateLogsData({ to }));
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await navigateToLogsExplorer();
     });
 

diff --git a/...onal/test_suites/observability/observability_logs_explorer/data_source_selection_state.ts b/...onal/test_suites/observability/observability_logs_explorer/data_source_selection_state.ts
@@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
   describe('dataSourceSelection initialization and update', () => {
     before(async () => {
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
     after(async () => {

diff --git a/.../functional/test_suites/observability/observability_logs_explorer/data_source_selector.ts b/.../functional/test_suites/observability/observability_logs_explorer/data_source_selector.ts
@@ -40,7 +40,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     // TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="dataSourceSelectorPopoverButton"])
     this.tags(['failsOnMKI']);
     before(async () => {
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await PageObjects.observabilityLogsExplorer.removeInstalledPackages();
     });
 

diff --git a/...serverless/functional/test_suites/observability/observability_logs_explorer/field_list.ts b/...serverless/functional/test_suites/observability/observability_logs_explorer/field_list.ts
@@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   describe('When virtual columns loads', () => {
     before(async () => {
       await synthtrace.index(generateLogsData({ from, to }));
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await navigateToLogsExplorer();
     });
 

diff --git a/...rless/functional/test_suites/observability/observability_logs_explorer/filter_controls.ts b/...rless/functional/test_suites/observability/observability_logs_explorer/filter_controls.ts
@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   describe('Filter controls customization', () => {
     before('initialize tests', async () => {
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
     after('clean up archives', async () => {

diff --git a/...est_serverless/functional/test_suites/observability/observability_logs_explorer/flyout.ts b/...est_serverless/functional/test_suites/observability/observability_logs_explorer/flyout.ts
@@ -45,7 +45,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         NAMESPACE
       );
       await PageObjects.observabilityLogsExplorer.ingestLogEntries(DATA_STREAM_NAME, docs);
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
     beforeEach(async () => {

diff --git a/...erverless/functional/test_suites/observability/observability_logs_explorer/header_menu.ts b/...erverless/functional/test_suites/observability/observability_logs_explorer/header_menu.ts
@@ -31,7 +31,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         'x-pack/test/functional/es_archives/observability_logs_explorer/data_streams'
       );
       await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await PageObjects.observabilityLogsExplorer.navigateTo();
       await PageObjects.header.waitUntilLoadingHasFinished();
     });

diff --git a/...serverless/functional/test_suites/observability/observability_logs_explorer/navigation.ts b/...serverless/functional/test_suites/observability/observability_logs_explorer/navigation.ts
@@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     before(async () => {
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
       await synthtrace.index(generateLogsData({ to }));
-      await PageObjects.svlCommonPage.login();
+      await PageObjects.svlCommonPage.loginWithRole('viewer');
       await navigateToLogsExplorer();
     });
 

diff --git a/x-pack/test_serverless/functional/test_suites/observability/rules/rules_list.ts b/x-pack/test_serverless/functional/test_suites/observability/rules/rules_list.ts
@@ -84,7 +84,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
     before(async () => {
       roleAuthc = await svlUserManager.createApiKeyForRole('admin');
       internalReqHeader = svlCommonApi.getInternalRequestHeader();
-      await svlCommonPage.login();
+      await svlCommonPage.loginWithRole('admin');
       await svlObltNavigation.navigateToLandingPage();
       await svlCommonNavigation.sidenav.clickLink({ text: 'Alerts' });
       await testSubjects.click('manageRulesPageButton');

diff --git a/...tional/test_suites/observability/screenshot_creation/response_ops_docs/cases/list_view.ts b/...tional/test_suites/observability/screenshot_creation/response_ops_docs/cases/list_view.ts
@@ -63,7 +63,7 @@ export default function ({ getPageObject, getPageObjects, getService }: FtrProvi
     });
 
     beforeEach(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
     it('cases list screenshot', async () => {

diff --git a/...es/observability/screenshot_creation/response_ops_docs/connectors/server_log_connector.ts b/...es/observability/screenshot_creation/response_ops_docs/connectors/server_log_connector.ts
@@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
   describe('server log connector', function () {
     beforeEach(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
     after(async () => {

diff --git a/.../observability/screenshot_creation/response_ops_docs/maintenance_windows/create_window.ts b/.../observability/screenshot_creation/response_ops_docs/maintenance_windows/create_window.ts
@@ -16,7 +16,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
   describe('create window', function () {
     beforeEach(async () => {
-      await pageObjects.svlCommonPage.login();
+      await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
     after(async () => {