-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BK] Migrate the kibana-on-merge job #184391
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b313885
chore(BK): Migrate the kibana-on-merge job
delanni 755ad79
use elastic-images-prod instead of the -qa projects
delanni 09dd17a
Merge branch 'main' into migrate-kibana-on-merge
delanni 1b1aa8d
Merge branch 'main' into migrate-kibana-on-merge
delanni d0bc2e5
Merge branch 'main' into migrate-kibana-on-merge
delanni ac59a71
chore: restrict 8.xx builds to 8.13/8.14
delanni 601b96e
Merge branch 'main' into migrate-kibana-on-merge
delanni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
.buildkite/pipeline-resource-definitions/kibana-on-merge.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # yaml-language-server: $schema=https://gist.githubusercontent.com/elasticmachine/988b80dae436cafea07d9a4a460a011d/raw/rre.schema.json | ||
| apiVersion: backstage.io/v1alpha1 | ||
| kind: Resource | ||
| metadata: | ||
| name: bk-kibana-on-merge | ||
| description: 'Runs for each commit of Kibana, i.e. each time a PR is merged' | ||
| links: | ||
| - url: 'https://buildkite.com/elastic/kibana-on-merge' | ||
| title: Pipeline link | ||
| spec: | ||
| type: buildkite-pipeline | ||
| owner: 'group:kibana-operations' | ||
| system: buildkite | ||
| implementation: | ||
| apiVersion: buildkite.elastic.dev/v1 | ||
| kind: Pipeline | ||
| metadata: | ||
| name: kibana / on merge | ||
| description: 'Runs for each commit of Kibana, i.e. each time a PR is merged' | ||
| spec: | ||
| env: | ||
| SLACK_NOTIFICATIONS_CHANNEL: '#kibana-operations-alerts' | ||
| GITHUB_BUILD_COMMIT_STATUS_ENABLED: 'true' | ||
| GITHUB_COMMIT_STATUS_CONTEXT: buildkite/on-merge | ||
| REPORT_FAILED_TESTS_TO_GITHUB: 'true' | ||
| ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true' | ||
| allow_rebuilds: true | ||
| branch_configuration: main 7.17 8.* | ||
| default_branch: main | ||
| repository: elastic/kibana | ||
| pipeline_file: .buildkite/pipelines/on_merge.yml | ||
| skip_intermediate_builds: false | ||
| provider_settings: | ||
| build_branches: true | ||
| build_pull_requests: false | ||
| publish_commit_status: false | ||
| trigger_mode: code | ||
| build_tags: false | ||
| prefix_pull_request_fork_branch_names: false | ||
| skip_pull_request_builds_for_existing_commits: false | ||
| teams: | ||
| everyone: | ||
| access_level: BUILD_AND_READ | ||
| kibana-operations: | ||
| access_level: MANAGE_BUILD_AND_READ | ||
| appex-qa: | ||
| access_level: MANAGE_BUILD_AND_READ | ||
| kibana-tech-leads: | ||
| access_level: MANAGE_BUILD_AND_READ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want all 8.x branches. Many of them aren't going to build, e.g. #167153.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same, but wouldn't the pipeline only run if there was a merge into an old branch? Which shouldn't happen anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does happen, documentation is still
builtsourced off old branches and fixes will be backported all the way back. exampleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, but then this still remains as something we'll need to update manually on minor bumps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we add several future versions up front, and just remove a few every now and then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to update it anyways for periodic pipelines, would adding future versions help much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's this attempt to try to do something about these pipelines that would depend on the supported versions:
#184018
This one avoids templates, but that would be the universal solution, I believe, if we need to factor these cases in