-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BK] Migrate the kibana-on-merge job #184391
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
REPORT_FAILED_TESTS_TO_GITHUB: 'true' | ||
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true' | ||
allow_rebuilds: true | ||
branch_configuration: main 7.17 8.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want all 8.x branches. Many of them aren't going to build, e.g. #167153.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same, but wouldn't the pipeline only run if there was a merge into an old branch? Which shouldn't happen anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does happen, documentation is still builtsourced off old branches and fixes will be backported all the way back. example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, but then this still remains as something we'll need to update manually on minor bumps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we add several future versions up front, and just remove a few every now and then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to update it anyways for periodic pipelines, would adding future versions help much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's this attempt to try to do something about these pipelines that would depend on the supported versions:
#184018
This one avoids templates, but that would be the universal solution, I believe, if we need to factor these cases in
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary Backport of #184391 to 8.14 Migration staging runs: - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/119 - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/122 Was flaky on Cypress tests, but after a retry it went away. Maybe it's the usual cypress flakiness?
## Summary Backport of #184391 to 7.17 Migration staging run: - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/106 - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/121
## Summary Backport of #184391 to 8.13 Test run successful, outside of a widely failing flaky FTR: https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/124
## Summary Backport of elastic#184391 to 7.17 Migration staging run: - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/106 - https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/121
Summary
This PR adds the pipeline resource definition and adjusts the agent targeting rules for the kibana-on-merge job.
Migration staging runs:
8.14: #184513
7.17: #184497