Move panel placement register to dashboard start contract #182571
Conversation
Also renames legacy placement method
|
/ci |
| } | ||
| return { width: 12, height: 8 }; | ||
| } | ||
| ); |
There was a problem hiding this comment.
I moved this to the start lifecycle since the method is provided by DashboardStart.
nickpeihl
added
Team:Presentation
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
botelastic
bot
added
the
ci:project-deploy-observability
|
/ci |
| @@ -159,6 +149,16 @@ export class SloPlugin | |||
| const kibanaVersion = this.initContext.env.packageInfo.version; | |||
| const { ruleTypeRegistry, actionTypeRegistry } = pluginsStart.triggersActionsUi; | |||
|
|
|||
| pluginsStart.dashboard.registerDashboardPanelPlacementSetting( | |||
There was a problem hiding this comment.
@nickpeihl The SLO feature is only for users with platinum license and above. Can you check for proper license here? Let me know if you want me to do the change and push directly to your branch
There was a problem hiding this comment.
@nickpeihl I was now checking a draft PR by @ThomThomson and I noticed he didn't move the registration to the start method. He kept things in the setup method.
In his case he changed to pluginsSetup.embeddable.registerReactEmbeddableFactory. So maybe you want to try doing something similar pluginsSetup.dashboard.registerDashboardPanelPlacementSetting, instead of moving the whole thing in the start method and having to do the platinum check ?
There was a problem hiding this comment.
Oops, you're right. I was misunderstanding the lifecycle. DashboardStart is available in the plugins' Setup lifecycle via the core.getStartServices method. Fixed in 79d8d9c.
There was a problem hiding this comment.
Ok looks good! Let me quickly try it out locally, and then I'll happily approve
There was a problem hiding this comment.
@nickpeihl I tested it and I verify that all works well!
…hboard-start' into panel-placement-dashboard-start
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
Part of #182585
Summary
Puts the
registerDashboardPanelPlacementSettingfunction on the Dashboard start contract.Rather than importing the module directly, consumers will need to include
dashboardin their plugin's start dependencies.