SLO plugin registers panel placement in setup

elastic · May 6, 2024 · 79d8d9c · 79d8d9c
1 parent a649b03
commit 79d8d9c
Showing 1 changed file with 10 additions and 14 deletions.
diff --git a/x-pack/plugins/observability_solution/slo/public/plugin.ts b/x-pack/plugins/observability_solution/slo/public/plugin.ts
@@ -94,9 +94,17 @@ export class SloPlugin
 
       const hasPlatinumLicense = license.hasAtLeast('platinum');
       if (hasPlatinumLicense) {
+        const [coreStart, pluginsStart] = await coreSetup.getStartServices();
+        pluginsStart.dashboard.registerDashboardPanelPlacementSetting(
+          SLO_OVERVIEW_EMBEDDABLE_ID,
+          (serializedState: SloOverviewEmbeddableState | undefined) => {
+            if (serializedState?.showAllGroupByInstances || serializedState?.groupFilters) {
+              return { width: 24, height: 8 };
+            }
+            return { width: 12, height: 8 };
+          }
+        );
         registerReactEmbeddableFactory(SLO_OVERVIEW_EMBEDDABLE_ID, async () => {
-          const [coreStart, pluginsStart] = await coreSetup.getStartServices();
-
           const deps = { ...coreStart, ...pluginsStart };
 
           const { getOverviewEmbeddableFactory } = await import(
@@ -117,8 +125,6 @@ export class SloPlugin
         registerSloAlertsEmbeddableFactory();
 
         registerReactEmbeddableFactory(SLO_ERROR_BUDGET_ID, async () => {
-          const [coreStart, pluginsStart] = await coreSetup.getStartServices();
-
           const deps = { ...coreStart, ...pluginsStart };
 
           const { getErrorBudgetEmbeddableFactory } = await import(
@@ -149,16 +155,6 @@ export class SloPlugin
     const kibanaVersion = this.initContext.env.packageInfo.version;
     const { ruleTypeRegistry, actionTypeRegistry } = pluginsStart.triggersActionsUi;
 
-    pluginsStart.dashboard.registerDashboardPanelPlacementSetting(
-      SLO_OVERVIEW_EMBEDDABLE_ID,
-      (serializedState: SloOverviewEmbeddableState | undefined) => {
-        if (serializedState?.showAllGroupByInstances || serializedState?.groupFilters) {
-          return { width: 24, height: 8 };
-        }
-        return { width: 12, height: 8 };
-      }
-    );
-
     return {
       getCreateSLOFlyout: getCreateSLOFlyoutLazy({
         core: coreStart,