Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action: undeploy serverless for closed PRs using ci:project-deploy-observability #182374

Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented May 2, 2024

Summary

Automate the undeployment for all those Kibana PRs using the label ci:project-deploy-observability once those PRs have been closed (merged, closed).

This will help with tidying up all the ongoing deployments that were created automatically as part of the recent automation with #181851

Requires elastic/apm-pipeline-library#2595

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v changed the title Feature/notify when GitHub kibana pr is closed github-action: undeploy serverless for closed PRs using ci:project-deploy-observability May 2, 2024
@v1v v1v marked this pull request as ready for review May 6, 2024 12:27
@v1v v1v requested a review from a team as a code owner May 6, 2024 12:27
@v1v v1v self-assigned this May 6, 2024
@v1v v1v requested review from kuisathaverat and a team May 6, 2024 12:28
@v1v v1v added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @v1v

@v1v v1v merged commit 63e29ef into elastic:main May 6, 2024
18 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants