Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labeller: enable serverless deployment for oblt automatically #181851

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 26, 2024

Summary

Use the probot labeller to tag any PRs that change anything related to the Observability solution.

The tag will automatically deploy a Serverless deployment with the Observability test data, see #181041

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Apr 26, 2024
@v1v v1v requested review from cachedout and kuisathaverat April 26, 2024 14:00
@v1v v1v self-assigned this Apr 26, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -27,3 +27,9 @@
- 'x-pack/plugins/observability_solution/observability_ai_assistant_*/**/*.*'
- 'x-pack/test/observability_ai_assistant_api_integration/**/*.*'
- 'x-pack/test/observability_ai_assistant_functional/**/*.*'
- 'ci:project-deploy-observability':
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if is_pr_with_label "ci:project-deploy-observability" ; then

@v1v v1v requested a review from a team April 26, 2024 14:12
@v1v v1v enabled auto-merge (squash) April 29, 2024 07:17
@v1v v1v merged commit 2f5897a into elastic:main Apr 29, 2024
6 checks passed
v1v added a commit that referenced this pull request May 6, 2024
…eploy-observability` (#182374)

Automate the undeployment for all those Kibana PRs using the label
`ci:project-deploy-observability` once those PRs have been closed
(merged, closed).

This will help with tidying up all the ongoing deployments that were
created automatically as part of the recent automation with
#181851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants